nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 16:34:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #33159 from frappe/mergify/bp/version-14-hotfix/pr-33136

Browse Source 
fix: reset `voucher_type` and `voucher_no` if `based_on` is set to `Transaction` (backport #33136)
This commit is contained in:
Sagar Sharma
2022-11-29 13:24:53 +05:30
committed by GitHub
parent 8ebf34629d 5728300f03
commit f2f06aaa56
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.js
View File

@@ -34,6 +34,22 @@ frappe.ui.form.on('Repost Item Valuation', {
frm.trigger('setup_realtime_progress'); frm.trigger('setup_realtime_progress');
}, },
based_on: function(frm) {
var fields_to_reset = [];
if (frm.doc.based_on == 'Transaction') {
fields_to_reset = ['item_code', 'warehouse'];
} else if (frm.doc.based_on == 'Item and Warehouse') {
fields_to_reset = ['voucher_type', 'voucher_no'];
}
if (fields_to_reset) {
fields_to_reset.forEach(field => {
frm.set_value(field, undefined);
});
}
},
setup_realtime_progress: function(frm) { setup_realtime_progress: function(frm) {
frappe.realtime.on('item_reposting_progress', data => { frappe.realtime.on('item_reposting_progress', data => {
if (frm.doc.name !== data.name) { if (frm.doc.name !== data.name) {

6
erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.json
View File

@@ -50,13 +50,15 @@
"fieldname": "posting_date", "fieldname": "posting_date",
"fieldtype": "Date", "fieldtype": "Date",
"label": "Posting Date", "label": "Posting Date",
"read_only_depends_on": "eval: doc.based_on == \"Transaction\"",
"reqd": 1 "reqd": 1
}, },
{ {
"fetch_from": "voucher_no.posting_time", "fetch_from": "voucher_no.posting_time",
"fieldname": "posting_time", "fieldname": "posting_time",
"fieldtype": "Time", "fieldtype": "Time",
"label": "Posting Time" "label": "Posting Time",
"read_only_depends_on": "eval: doc.based_on == \"Transaction\""
}, },
{ {
"default": "Queued", "default": "Queued",
@@ -195,7 +197,7 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"is_submittable": 1, "is_submittable": 1,
"links": [], "links": [],
"modified": "2022-06-13 12:20:22.182322", "modified": "2022-11-28 16:00:05.637440",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Stock", "module": "Stock",
"name": "Repost Item Valuation", "name": "Repost Item Valuation",