From f2ee36579b10cb9f913cebf5705e8be19f1410a7 Mon Sep 17 00:00:00 2001 From: Rucha Mahabal Date: Wed, 23 Feb 2022 11:22:58 +0530 Subject: [PATCH] chore: sort imports, remove unused imports --- erpnext/hr/doctype/attendance/attendance.py | 2 +- erpnext/hr/doctype/shift_assignment/shift_assignment.py | 9 ++++----- erpnext/hr/doctype/shift_type/shift_type.py | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/erpnext/hr/doctype/attendance/attendance.py b/erpnext/hr/doctype/attendance/attendance.py index 2d8bf15201c..ae0f2e7c103 100644 --- a/erpnext/hr/doctype/attendance/attendance.py +++ b/erpnext/hr/doctype/attendance/attendance.py @@ -5,8 +5,8 @@ import frappe from frappe import _ from frappe.model.document import Document -from frappe.utils import cint, cstr, formatdate, get_datetime, get_link_to_form, getdate, nowdate from frappe.query_builder import Criterion +from frappe.utils import cint, cstr, formatdate, get_datetime, get_link_to_form, getdate, nowdate from erpnext.hr.utils import get_holiday_dates_for_employee, validate_active_employee diff --git a/erpnext/hr/doctype/shift_assignment/shift_assignment.py b/erpnext/hr/doctype/shift_assignment/shift_assignment.py index 702d3a25063..768a86258ef 100644 --- a/erpnext/hr/doctype/shift_assignment/shift_assignment.py +++ b/erpnext/hr/doctype/shift_assignment/shift_assignment.py @@ -3,19 +3,18 @@ from datetime import datetime, timedelta +from typing import Dict, List import frappe from frappe import _ from frappe.model.document import Document -from frappe.query_builder import Criterion, Column -from frappe.utils import cstr, get_link_to_form, get_datetime, get_time, getdate, now_datetime, nowdate +from frappe.query_builder import Criterion +from frappe.utils import cstr, get_datetime, get_link_to_form, get_time, getdate, now_datetime from erpnext.hr.doctype.employee.employee import get_holiday_list_for_employee from erpnext.hr.doctype.holiday_list.holiday_list import is_holiday from erpnext.hr.utils import validate_active_employee -from typing import Dict, List - class OverlappingShiftError(frappe.ValidationError): pass @@ -374,7 +373,7 @@ def get_exact_shift(shifts: List, for_timestamp: datetime) -> Dict: timestamp_index = index elif for_timestamp == timestamp: # on timestamp boundary - if index%2 == 1: + if index % 2 == 1: timestamp_index = index else: timestamp_index = index + 1 diff --git a/erpnext/hr/doctype/shift_type/shift_type.py b/erpnext/hr/doctype/shift_type/shift_type.py index 27d368ca0a9..dd1dff1bc4d 100644 --- a/erpnext/hr/doctype/shift_type/shift_type.py +++ b/erpnext/hr/doctype/shift_type/shift_type.py @@ -19,7 +19,7 @@ from erpnext.hr.doctype.employee_checkin.employee_checkin import ( from erpnext.hr.doctype.holiday_list.holiday_list import is_holiday from erpnext.hr.doctype.shift_assignment.shift_assignment import ( get_employee_shift, - get_shift_details + get_shift_details, )