nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-13 02:01:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(employee): create user function -removed useless function calls

Browse Source 
(cherry picked from commit 6513185cb7)
This commit is contained in:
Krishna Shirsath
2026-02-19 17:00:35 +05:30
committed by Mergify
parent 8f8b48746b
commit f2c4a8b1c4
1 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/setup/doctype/employee/employee.py
View File

@@ -449,9 +449,6 @@ def create_user(employee, user=None, email=None, create_user_permission=0):
first_name = employee_name[0] first_name = employee_name[0]
frappe.db.set_value("Employee", emp.name, "user_id", email, update_modified=False)
frappe.db.commit()
user = frappe.new_doc("User") user = frappe.new_doc("User")
user.update( user.update(
{ {
@@ -467,8 +464,9 @@ def create_user(employee, user=None, email=None, create_user_permission=0):
"bio": emp.bio, "bio": emp.bio,
} }
) )
frappe.db.set_value("Employee", emp.name, "user_id", email)
user.append_roles("Employee") user.append_roles("Employee")
user.insert(ignore_permissions=True) user.insert()
emp.reload() emp.reload()
emp.company_email = email emp.company_email = email
@@ -477,17 +475,8 @@ def create_user(employee, user=None, email=None, create_user_permission=0):
emp.save() emp.save()
if cint(create_user_permission): if cint(create_user_permission):
if not frappe.db.exists( add_user_permission("Employee", emp.name, user.name)
"User Permission", add_user_permission("Company", emp.company, user.name)
{"allow": "Employee", "for_value": emp.name, "user": user.name},
):
add_user_permission("Employee", emp.name, user.name)
if not frappe.db.exists(
"User Permission",
{"allow": "Company", "for_value": emp.company, "user": user.name},
):
add_user_permission("Company", emp.company, user.name)
return user.name return user.name