nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 22:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56485 from mihir-kandoi/messages-js/public

Browse Source 
chore: rewrite user-facing JS messages in public module
This commit is contained in:
Mihir Kandoi
2026-06-25 17:56:19 +05:30
committed by GitHub
parent 27a7ec82c2 8cd420953c
commit f151b2abee
6 changed files with 20 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/public/js/bulk_transaction_processing.js
View File

@@ -25,10 +25,9 @@ $.extend(erpnext.bulk_transaction_processing, {
})
.then(() => {});
if (count_of_rows > 10) {
frappe.show_alert("Starting a background job to create {0} {1}", [
count_of_rows,
__(to_doctype),
]);
frappe.show_alert(
__("Starting a background job to create {0} {1}", [count_of_rows, __(to_doctype)])
);
}
} else {
frappe.msgprint(__("Selected document must be in submitted state"));

2
erpnext/public/js/controllers/accounts.js
View File

@@ -228,7 +228,7 @@ erpnext.accounts.taxes = {
on_previous_row_error(tax.row_id == 1 ? "1" : "1 - " + tax.row_id);
}
} else if (tax.category == "Valuation") {
frappe.throw(__("Valuation type charges can not marked as Inclusive"));
frappe.throw(__("Valuation type charges cannot be marked as Inclusive"));
}
}
},

4
erpnext/public/js/controllers/buying.js
View File

@@ -552,10 +552,10 @@ erpnext.buying.link_to_mrs = function (frm) {
item.qty = my_qty;
frappe.msgprint(
"Assigning " + d.mr_name + " to " + d.item_code + " (row " + item.idx + ")"
__("Assigning {0} to {1} (row {2})", [d.mr_name, d.item_code, item.idx])
);
if (qty > 0) {
frappe.msgprint("Splitting " + qty + " units of " + d.item_code);
frappe.msgprint(__("Splitting {0} units of {1}", [qty, d.item_code]));
var newrow = frappe.model.add_child(frm.doc, item.doctype, "items");
item_length++;

8
erpnext/public/js/controllers/transaction.js
View File

@@ -2635,11 +2635,9 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
) {
if (!me.frm.doc[fieldname]) {
frappe.msgprint(
__("Please specify") +
": " +
__(frappe.meta.get_label(me.frm.doc.doctype, fieldname, me.frm.doc.name)) +
". " +
__("It is needed to fetch Item Details.")
__("Please specify {0}. It is needed to fetch Item Details.", [
__(frappe.meta.get_label(me.frm.doc.doctype, fieldname, me.frm.doc.name)),
])
);
valid = false;
}

12
erpnext/public/js/utils/sales_common.js
View File

@@ -331,9 +331,15 @@ erpnext.sales_common = {
if (this.frm.doc.commission_rate > 100) {
this.frm.set_value("commission_rate", 100);
frappe.throw(
`${__(
frappe.meta.get_label(this.frm.doc.doctype, "commission_rate", this.frm.doc.name)
)} ${__("cannot be greater than 100")}`
__("{0} cannot be greater than 100", [
__(
frappe.meta.get_label(
this.frm.doc.doctype,
"commission_rate",
this.frm.doc.name
)
),
])
);
}

4
erpnext/public/js/utils/serial_no_batch_selector.js
View File

@@ -660,7 +660,7 @@ erpnext.SerialBatchPackageSelector = class SerialNoBatchBundleUpdate {
}
if ((entries && !entries.length) || !entries) {
frappe.throw(__("Please add atleast one Serial No / Batch No"));
frappe.throw(__("Please add at least one Serial No / Batch No"));
}
if (!warehouse) {
@@ -668,7 +668,7 @@ erpnext.SerialBatchPackageSelector = class SerialNoBatchBundleUpdate {
}
if (this.item?.is_rejected && this.item.rejected_warehouse === this.item.warehouse) {
frappe.throw(__("Rejected Warehouse and Accepted Warehouse cannot be same."));
frappe.throw(__("Rejected Warehouse and Accepted Warehouse cannot be the same."));
}
frappe