From f03a81b943dacafa2ece81e1f23b8eb0075f2f34 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Fri, 19 Jun 2026 22:11:05 +0530 Subject: [PATCH] refactor(stock): use get_all for warehouse subtree in capacity dashboard Replace the raw lft/rgt SELECT with frappe.get_all(pluck="name"). Same result on MariaDB; valid under Postgres. Co-Authored-By: Claude Opus 4.8 (1M context) --- erpnext/stock/dashboard/warehouse_capacity_dashboard.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/erpnext/stock/dashboard/warehouse_capacity_dashboard.py b/erpnext/stock/dashboard/warehouse_capacity_dashboard.py index 1d550010315..24944047ef2 100644 --- a/erpnext/stock/dashboard/warehouse_capacity_dashboard.py +++ b/erpnext/stock/dashboard/warehouse_capacity_dashboard.py @@ -40,12 +40,8 @@ def get_filters(item_code=None, warehouse=None, parent_warehouse=None, company=N filters.append(["company", "=", company]) if parent_warehouse: lft, rgt = frappe.db.get_value("Warehouse", parent_warehouse, ["lft", "rgt"]) - warehouses = frappe.db.sql_list( - """ - select name from `tabWarehouse` - where lft >=%s and rgt<=%s - """, - (lft, rgt), + warehouses = frappe.get_all( + "Warehouse", filters={"lft": [">=", lft], "rgt": ["<=", rgt]}, pluck="name" ) filters.append(["warehouse", "in", warehouses]) return filters