nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-11 08:53:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: disallow BOM finished good item in secondary items table (backport #55710) (#55719)

Browse Source 
Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
fix: disallow BOM finished good item in secondary items table (#55710)
This commit is contained in:
mergify[bot]
2026-06-08 13:40:59 +05:30
committed by GitHub
parent 8f85cce4cf
commit ecd3a19912
2 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/manufacturing/doctype/bom/bom.py
View File

@@ -334,6 +334,13 @@ class BOM(WebsiteGenerator):
def validate_secondary_items(self):
for item in self.secondary_items:
if not item.is_legacy and item.item_code == self.item:
frappe.throw(
_(
"Row #{0}: Finished Good Item {1} cannot be added in the Secondary Items table."
).format(item.idx, get_link_to_form("Item", item.item_code))
)
if not item.qty:
frappe.throw(
_("Row #{0}: Quantity should be greater than 0 for {1} Item {2}").format(

24
erpnext/manufacturing/doctype/bom/test_bom.py
View File

@@ -444,6 +444,30 @@ class TestBOM(ERPNextTestSuite):
# Items with whole UOMs can't be PL Items
self.assertRaises(frappe.ValidationError, bom_doc.submit)
@timeout
def test_fg_item_not_allowed_in_secondary_items(self):
fg_item = make_item(properties={"is_stock_item": 1, "valuation_rate": 100}).name
rm_item = make_item(properties={"is_stock_item": 1, "valuation_rate": 100}).name
bom_doc = frappe.new_doc("BOM")
bom_doc.item = fg_item
bom_doc.quantity = 1
bom_doc.company = "_Test Company"
bom_doc.currency = "INR"
bom_doc.append("items", {"item_code": rm_item, "qty": 1, "rate": 100.0})
bom_doc.append(
"secondary_items",
{
"item_code": fg_item,
"secondary_item_type": "Additional Finished Good",
"qty": 1,
"cost_allocation_per": 10,
},
)
# FG item of the BOM cannot also be a secondary item
self.assertRaises(frappe.ValidationError, bom_doc.save)
@timeout
def test_bom_item_query(self):
query = partial(