nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-14 02:31:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify conditional logic

Browse Source 
Command: `sourcery review --fix --enable de-morgan .`
This commit is contained in:
barredterra
2023-12-05 11:22:55 +01:00
parent 5da3e532c9
commit eb9ee3f79b
51 changed files with 104 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/support/doctype/service_level_agreement/service_level_agreement.py
View File

@@ -100,7 +100,7 @@ class ServiceLevelAgreement(Document):
priorities.append(priority.priority)
# Check if repeated priority
if not len(set(priorities)) == len(priorities):
if len(set(priorities)) != len(priorities):
repeated_priority = get_repeated(priorities)
frappe.throw(_("Priority {0} has been repeated.").format(repeated_priority))
@@ -128,7 +128,7 @@ class ServiceLevelAgreement(Document):
)
# Check for repeated workday
if not len(set(support_days)) == len(support_days):
if len(set(support_days)) != len(support_days):
repeated_days = get_repeated(support_days)
frappe.throw(_("Workday {0} has been repeated.").format(repeated_days))
@@ -748,13 +748,13 @@ def change_service_level_agreement_and_priority(self):
and frappe.db.get_single_value("Support Settings", "track_service_level_agreement")
):
if not self.priority == frappe.db.get_value("Issue", self.name, "priority"):
if self.priority != frappe.db.get_value("Issue", self.name, "priority"):
self.set_response_and_resolution_time(
priority=self.priority, service_level_agreement=self.service_level_agreement
)
frappe.msgprint(_("Priority has been changed to {0}.").format(self.priority))
if not self.service_level_agreement == frappe.db.get_value(
if self.service_level_agreement != frappe.db.get_value(
"Issue", self.name, "service_level_agreement"
):
self.set_response_and_resolution_time(