mirror of
https://github.com/frappe/erpnext.git
synced 2026-05-29 18:04:46 +00:00
Merge branch 'develop' of https://github.com/frappe/erpnext into quotation_issues
This commit is contained in:
@@ -244,11 +244,10 @@ class GSTR3BReport(Document):
|
||||
)
|
||||
|
||||
for d in item_details:
|
||||
if d.item_code not in self.invoice_items.get(d.parent, {}):
|
||||
self.invoice_items.setdefault(d.parent, {}).setdefault(d.item_code, 0.0)
|
||||
self.invoice_items[d.parent][d.item_code] += d.get("taxable_value", 0) or d.get(
|
||||
"base_net_amount", 0
|
||||
)
|
||||
self.invoice_items.setdefault(d.parent, {}).setdefault(d.item_code, 0.0)
|
||||
self.invoice_items[d.parent][d.item_code] += d.get("taxable_value", 0) or d.get(
|
||||
"base_net_amount", 0
|
||||
)
|
||||
|
||||
if d.is_nil_exempt and d.item_code not in self.is_nil_exempt:
|
||||
self.is_nil_exempt.append(d.item_code)
|
||||
@@ -335,7 +334,6 @@ class GSTR3BReport(Document):
|
||||
|
||||
def set_outward_taxable_supplies(self):
|
||||
inter_state_supply_details = {}
|
||||
|
||||
for inv, items_based_on_rate in self.items_based_on_tax_rate.items():
|
||||
gst_category = self.invoice_detail_map.get(inv, {}).get("gst_category")
|
||||
place_of_supply = (
|
||||
@@ -361,7 +359,6 @@ class GSTR3BReport(Document):
|
||||
else:
|
||||
self.report_dict["sup_details"]["osup_det"]["iamt"] += taxable_value * rate / 100
|
||||
self.report_dict["sup_details"]["osup_det"]["txval"] += taxable_value
|
||||
|
||||
if (
|
||||
gst_category in ["Unregistered", "Registered Composition", "UIN Holders"]
|
||||
and self.gst_details.get("gst_state") != place_of_supply.split("-")[1]
|
||||
|
||||
@@ -55,6 +55,9 @@ def validate_eligibility(doc):
|
||||
return False
|
||||
|
||||
invalid_company = not frappe.db.get_value("E Invoice User", {"company": doc.get("company")})
|
||||
invalid_company_gstin = not frappe.db.get_value(
|
||||
"E Invoice User", {"gstin": doc.get("company_gstin")}
|
||||
)
|
||||
invalid_supply_type = doc.get("gst_category") not in [
|
||||
"Registered Regular",
|
||||
"Registered Composition",
|
||||
@@ -71,6 +74,7 @@ def validate_eligibility(doc):
|
||||
|
||||
if (
|
||||
invalid_company
|
||||
or invalid_company_gstin
|
||||
or invalid_supply_type
|
||||
or company_transaction
|
||||
or no_taxes_applied
|
||||
|
||||
Reference in New Issue
Block a user