From 3790c6c551dd03e9b9235a8732c526dd25a3e14a Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Fri, 25 Apr 2025 14:06:31 +0530 Subject: [PATCH 1/3] fix: add transaction_date in field_no_map when creating PO from SQ --- erpnext/buying/doctype/supplier_quotation/supplier_quotation.py | 1 + 1 file changed, 1 insertion(+) diff --git a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py index 0829b27151f..84f9a1657c7 100644 --- a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py +++ b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py @@ -234,6 +234,7 @@ def make_purchase_order(source_name, target_doc=None): { "Supplier Quotation": { "doctype": "Purchase Order", + "field_no_map": ["transaction_date"], "validation": { "docstatus": ["=", 1], }, From acd152978092d7fcb9a6b82cf47be7d46a4470d8 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Mon, 28 Apr 2025 17:43:19 +0530 Subject: [PATCH 2/3] fix: test case --- .../doctype/supplier_quotation/test_supplier_quotation.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py b/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py index dad2cba4877..e170d4b8ec6 100644 --- a/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py +++ b/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py @@ -3,7 +3,9 @@ import frappe +import frappe.utils from frappe.tests import IntegrationTestCase, UnitTestCase +from frappe.utils import add_days, today from erpnext.controllers.accounts_controller import InvalidQtyError @@ -47,6 +49,6 @@ class TestPurchaseOrder(IntegrationTestCase): for doc in po.get("items"): if doc.get("item_code"): - doc.set("schedule_date", "2013-04-12") + doc.set("schedule_date", add_days(today(), 1)) po.insert() From 9e640341fd8410b6e2fe4bfddad8188ceb0134ab Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Mon, 28 Apr 2025 17:49:27 +0530 Subject: [PATCH 3/3] fix: remove unused import --- .../buying/doctype/supplier_quotation/test_supplier_quotation.py | 1 - 1 file changed, 1 deletion(-) diff --git a/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py b/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py index e170d4b8ec6..0e4f70b9dcb 100644 --- a/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py +++ b/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py @@ -3,7 +3,6 @@ import frappe -import frappe.utils from frappe.tests import IntegrationTestCase, UnitTestCase from frappe.utils import add_days, today