nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-14 02:31:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(asset): make asset depreciation failure notification role configurable

Browse Source
This commit is contained in:
SowmyaArunachalam
2025-11-25 22:28:26 +05:30
parent a8d3e9bacc
commit e830cca886
3 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/accounts/doctype/accounts_settings/accounts_settings.json
View File

@@ -73,6 +73,7 @@
"calculate_depr_using_total_days", "calculate_depr_using_total_days",
"column_break_gjcc", "column_break_gjcc",
"book_asset_depreciation_entry_automatically", "book_asset_depreciation_entry_automatically",
"role_used_for_depreciation_failure",
"closing_settings_tab", "closing_settings_tab",
"period_closing_settings_section", "period_closing_settings_section",
"acc_frozen_upto", "acc_frozen_upto",
@@ -658,6 +659,13 @@
"fieldname": "use_legacy_controller_for_pcv", "fieldname": "use_legacy_controller_for_pcv",
"fieldtype": "Check", "fieldtype": "Check",
"label": "Use Legacy Controller For Period Closing Voucher" "label": "Use Legacy Controller For Period Closing Voucher"
},
{
"description": "Users with this role will be notified if the asset depreciation gets failed",
"fieldname": "role_used_for_depreciation_failure",
"fieldtype": "Link",
"label": "Role used for Depreciation Failure",
"options": "Role"
} }
], ],
"grid_page_length": 50, "grid_page_length": 50,
@@ -666,7 +674,7 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"issingle": 1, "issingle": 1,
"links": [], "links": [],
"modified": "2025-10-20 14:06:08.870427", "modified": "2025-11-24 23:36:21.829372",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Accounts Settings", "name": "Accounts Settings",

1
erpnext/accounts/doctype/accounts_settings/accounts_settings.py
View File

@@ -65,6 +65,7 @@ class AccountsSettings(Document):
reconciliation_queue_size: DF.Int reconciliation_queue_size: DF.Int
role_allowed_to_over_bill: DF.Link | None role_allowed_to_over_bill: DF.Link | None
role_to_override_stop_action: DF.Link | None role_to_override_stop_action: DF.Link | None
role_used_for_depreciation_failure: DF.Link | None
round_row_wise_tax: DF.Check round_row_wise_tax: DF.Check
show_balance_in_coa: DF.Check show_balance_in_coa: DF.Check
show_inclusive_tax_in_print: DF.Check show_inclusive_tax_in_print: DF.Check

3
erpnext/assets/doctype/asset/depreciation.py
View File

@@ -307,7 +307,8 @@ def set_depr_entry_posting_status_for_failed_assets(failed_asset_names):
def notify_depr_entry_posting_error(failed_asset_names, error_log_names): def notify_depr_entry_posting_error(failed_asset_names, error_log_names):
recipients = get_users_with_role("Accounts Manager") user_role = frappe.db.get_single_value("Accounts Settings", "role_used_for_depreciation_failure")
recipients = get_users_with_role(user_role or "Accounts Manager")
if not recipients: if not recipients:
recipients = get_users_with_role("System Manager") recipients = get_users_with_role("System Manager")