feat(accounts): opt-in 'Consider Accounting Dimension' filter on General Ledger Report (backport #58156) (#58157)

Co-authored-by: Diptanil Saha <diptanil@frappe.io>
This commit is contained in:
mergify[bot]
2026-08-14 16:27:37 +05:30
committed by GitHub
parent faaaa0776d
commit e704e589ca
4 changed files with 17 additions and 6 deletions

View File

@@ -89,13 +89,14 @@
"enable_fuzzy_matching", "enable_fuzzy_matching",
"reports_tab", "reports_tab",
"remarks_section", "remarks_section",
"general_ledger_remarks_length", "disable_include_dimensions",
"column_break_lvjk", "column_break_lvjk",
"receivable_payable_remarks_length", "general_ledger_remarks_length",
"accounts_receivable_payable_tuning_section", "accounts_receivable_payable_tuning_section",
"receivable_payable_fetch_method", "receivable_payable_fetch_method",
"default_ageing_range", "default_ageing_range",
"column_break_ntmi", "column_break_ntmi",
"receivable_payable_remarks_length",
"legacy_section", "legacy_section",
"ignore_is_opening_check_for_reporting", "ignore_is_opening_check_for_reporting",
"payment_request_settings", "payment_request_settings",
@@ -483,7 +484,7 @@
{ {
"fieldname": "remarks_section", "fieldname": "remarks_section",
"fieldtype": "Section Break", "fieldtype": "Section Break",
"label": "Remarks Column Length" "label": "General Ledger Report"
}, },
{ {
"default": "0", "default": "0",
@@ -566,7 +567,7 @@
{ {
"fieldname": "accounts_receivable_payable_tuning_section", "fieldname": "accounts_receivable_payable_tuning_section",
"fieldtype": "Section Break", "fieldtype": "Section Break",
"label": "Accounts Receivable / Payable Tuning" "label": "Accounts Receivable / Payable Report"
}, },
{ {
"fieldname": "legacy_section", "fieldname": "legacy_section",
@@ -665,6 +666,12 @@
"fieldname": "default_ageing_range", "fieldname": "default_ageing_range",
"fieldtype": "Data", "fieldtype": "Data",
"label": "Default Ageing Range" "label": "Default Ageing Range"
},
{
"default": "0",
"fieldname": "disable_include_dimensions",
"fieldtype": "Check",
"label": "Disable \"Consider Accounting Dimension\" Filter"
} }
], ],
"icon": "icon-cog", "icon": "icon-cog",
@@ -672,7 +679,7 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"issingle": 1, "issingle": 1,
"links": [], "links": [],
"modified": "2026-06-24 12:59:41.868865", "modified": "2026-08-14 13:12:47.895908",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Accounts Settings", "name": "Accounts Settings",

View File

@@ -44,6 +44,7 @@ class AccountsSettings(Document):
default_ageing_range: DF.Data | None default_ageing_range: DF.Data | None
delete_linked_ledger_entries: DF.Check delete_linked_ledger_entries: DF.Check
determine_address_tax_category_from: DF.Literal["Billing Address", "Shipping Address"] determine_address_tax_category_from: DF.Literal["Billing Address", "Shipping Address"]
disable_include_dimensions: DF.Check
enable_common_party_accounting: DF.Check enable_common_party_accounting: DF.Check
enable_fuzzy_matching: DF.Check enable_fuzzy_matching: DF.Check
enable_immutable_ledger: DF.Check enable_immutable_ledger: DF.Check

View File

@@ -174,7 +174,7 @@ frappe.query_reports["General Ledger"] = {
fieldname: "include_dimensions", fieldname: "include_dimensions",
label: __("Consider Accounting Dimensions"), label: __("Consider Accounting Dimensions"),
fieldtype: "Check", fieldtype: "Check",
default: 1, default: frappe.boot.sysdefaults.disable_include_dimensions ? 0 : 1,
}, },
{ {
fieldname: "disable_opening_balance_calculation", fieldname: "disable_opening_balance_calculation",

View File

@@ -25,6 +25,9 @@ def boot_session(bootinfo):
bootinfo.sysdefaults.over_billing_allowance = frappe.db.get_single_value( bootinfo.sysdefaults.over_billing_allowance = frappe.db.get_single_value(
"Accounts Settings", "over_billing_allowance" "Accounts Settings", "over_billing_allowance"
) )
bootinfo.sysdefaults.disable_include_dimensions = cint(
frappe.get_single_value("Accounts Settings", "disable_include_dimensions")
)
bootinfo.sysdefaults.quotation_valid_till = cint( bootinfo.sysdefaults.quotation_valid_till = cint(
frappe.db.get_single_value("CRM Settings", "default_valid_till") frappe.db.get_single_value("CRM Settings", "default_valid_till")