nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-25 21:05:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): hardcoded names over dynamic ones

Browse Source 
Much faster bootstrap without those get_doc calls
This commit is contained in:
ruthra kumar
2026-03-01 21:33:45 +05:30
parent 5a4a77f5d2
commit e67165d6ce
26 changed files with 67 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/setup/doctype/department/test_department.py
View File

@@ -8,7 +8,7 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestDepartment(ERPNextTestSuite):
def test_remove_department_data(self):
doc = create_department("Test Department", company=self.companies[0].name)
doc = create_department("Test Department", company="_Test Company")
frappe.delete_doc("Department", doc.name)

12
erpnext/setup/doctype/employee/test_employee.py
View File

@@ -13,8 +13,8 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestEmployee(ERPNextTestSuite):
def test_employee_status_left(self):
employee1 = make_employee("test_employee_1@company.com", company=self.companies[0].name)
employee2 = make_employee("test_employee_2@company.com", company=self.companies[0].name)
employee1 = make_employee("test_employee_1@company.com", company="_Test Company")
employee2 = make_employee("test_employee_2@company.com", company="_Test Company")
employee1_doc = frappe.get_doc("Employee", employee1)
employee2_doc = frappe.get_doc("Employee", employee2)
employee2_doc.reload()
@@ -25,7 +25,7 @@ class TestEmployee(ERPNextTestSuite):
self.assertRaises(InactiveEmployeeStatusError, employee1_doc.save)
def test_user_has_employee(self):
employee = make_employee("test_emp_user_creation@company.com", company=self.companies[0].name)
employee = make_employee("test_emp_user_creation@company.com", company="_Test Company")
employee_doc = frappe.get_doc("Employee", employee)
user = employee_doc.user_id
self.assertTrue("Employee" in frappe.get_roles(user))
@@ -35,12 +35,12 @@ class TestEmployee(ERPNextTestSuite):
def test_employee_user_permission(self):
employee1 = make_employee(
"employee_1_test@company.com", create_user_permission=1, company=self.companies[0].name
"employee_1_test@company.com", create_user_permission=1, company="_Test Company"
)
employee2 = make_employee(
"employee_2_test@company.com", create_user_permission=1, company=self.companies[0].name
"employee_2_test@company.com", create_user_permission=1, company="_Test Company"
)
make_employee("employee_3_test@company.com", create_user_permission=1, company=self.companies[0].name)
make_employee("employee_3_test@company.com", create_user_permission=1, company="_Test Company")
employee1_doc = frappe.get_doc("Employee", employee1)
employee2_doc = frappe.get_doc("Employee", employee2)