nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 00:14:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #45040 from ruthra-kumar/use_idx_for_identifying

Browse Source 
refactor: use `idx` for identifying row
This commit is contained in:
ruthra kumar
2025-01-02 12:16:40 +05:30
committed by GitHub
parent 1f26feca2e 51354c894a
commit e609a6a038
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/controllers/tests/test_reactivity.py
View File

@@ -56,7 +56,7 @@ class TestReactivity(AccountsTestMixin, IntegrationTestCase):
) )
itm = si.append("items") itm = si.append("items")
itm.item_code = self.item itm.item_code = self.item
si.process_item_selection(si.items[0].name) si.process_item_selection(itm.idx)
self.assertEqual(itm.rate, 90) self.assertEqual(itm.rate, 90)
df = qb.DocType("DocField") df = qb.DocType("DocField")

2
erpnext/public/js/controllers/transaction.js
View File

@@ -505,7 +505,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
doc: doc, doc: doc,
method: "process_item_selection", method: "process_item_selection",
args: { args: {
item: item.name item_idx: item.idx
}, },
callback: function(r) { callback: function(r) {
if(!r.exc) { if(!r.exc) {

4
erpnext/utilities/transaction_base.py
View File

@@ -288,9 +288,9 @@ class TransactionBase(StatusUpdater):
) )
@frappe.whitelist() @frappe.whitelist()
def process_item_selection(self, item): def process_item_selection(self, item_idx):
# Server side 'item' doc. Update this to reflect in UI # Server side 'item' doc. Update this to reflect in UI
item_obj = self.get("items", {"name": item})[0] item_obj = self.get("items", {"idx": item_idx})[0]
# 'item_details' has latest item related values # 'item_details' has latest item related values
item_details = self.fetch_item_details(item_obj) item_details = self.fetch_item_details(item_obj)