From 51354c894af00648e4a81b2bc384a2ea67c2f725 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Thu, 2 Jan 2025 11:29:27 +0530 Subject: [PATCH] refactor: use `idx` for identifying row --- erpnext/controllers/tests/test_reactivity.py | 2 +- erpnext/public/js/controllers/transaction.js | 2 +- erpnext/utilities/transaction_base.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/erpnext/controllers/tests/test_reactivity.py b/erpnext/controllers/tests/test_reactivity.py index 73f7962836c..b6baad2fab2 100644 --- a/erpnext/controllers/tests/test_reactivity.py +++ b/erpnext/controllers/tests/test_reactivity.py @@ -56,7 +56,7 @@ class TestReactivity(AccountsTestMixin, IntegrationTestCase): ) itm = si.append("items") itm.item_code = self.item - si.process_item_selection(si.items[0].name) + si.process_item_selection(itm.idx) self.assertEqual(itm.rate, 90) df = qb.DocType("DocField") diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js index 250f7c70c7a..32b46f3bc1e 100644 --- a/erpnext/public/js/controllers/transaction.js +++ b/erpnext/public/js/controllers/transaction.js @@ -505,7 +505,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe doc: doc, method: "process_item_selection", args: { - item: item.name + item_idx: item.idx }, callback: function(r) { if(!r.exc) { diff --git a/erpnext/utilities/transaction_base.py b/erpnext/utilities/transaction_base.py index 97b274da576..84f740e151d 100644 --- a/erpnext/utilities/transaction_base.py +++ b/erpnext/utilities/transaction_base.py @@ -288,9 +288,9 @@ class TransactionBase(StatusUpdater): ) @frappe.whitelist() - def process_item_selection(self, item): + def process_item_selection(self, item_idx): # Server side 'item' doc. Update this to reflect in UI - item_obj = self.get("items", {"name": item})[0] + item_obj = self.get("items", {"idx": item_idx})[0] # 'item_details' has latest item related values item_details = self.fetch_item_details(item_obj)