nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-26 10:08:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: enqueue_after_commit wherever it makes sense (backport #35588) (#35590)

Browse Source 
fix: `enqueue_after_commit` wherever it makes sense (#35588)

(cherry picked from commit 4507cb3cd7)

Co-authored-by: Ankush Menat <ankush@frappe.io>
This commit is contained in:
mergify[bot]
2023-06-07 15:27:45 +05:30
committed by GitHub
parent a8ac2a088d
commit e5055160fb
5 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py
View File

@@ -50,13 +50,15 @@ class AccountingDimension(Document):
if frappe.flags.in_test: if frappe.flags.in_test:
make_dimension_in_accounting_doctypes(doc=self) make_dimension_in_accounting_doctypes(doc=self)
else: else:
frappe.enqueue(make_dimension_in_accounting_doctypes, doc=self, queue="long") frappe.enqueue(
make_dimension_in_accounting_doctypes, doc=self, queue="long", enqueue_after_commit=True
)
def on_trash(self): def on_trash(self):
if frappe.flags.in_test: if frappe.flags.in_test:
delete_accounting_dimension(doc=self) delete_accounting_dimension(doc=self)
else: else:
frappe.enqueue(delete_accounting_dimension, doc=self, queue="long") frappe.enqueue(delete_accounting_dimension, doc=self, queue="long", enqueue_after_commit=True)
def set_fieldname_and_label(self): def set_fieldname_and_label(self):
if not self.label: if not self.label:

1
erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
View File

@@ -35,6 +35,7 @@ class PeriodClosingVoucher(AccountsController):
voucher_type="Period Closing Voucher", voucher_type="Period Closing Voucher",
voucher_no=self.name, voucher_no=self.name,
queue="long", queue="long",
enqueue_after_commit=True,
) )
frappe.msgprint( frappe.msgprint(
_("The GL Entries will be cancelled in the background, it can take a few minutes."), alert=True _("The GL Entries will be cancelled in the background, it can take a few minutes."), alert=True

2
erpnext/manufacturing/doctype/bom_update_log/bom_update_log.py
View File

@@ -88,12 +88,14 @@ class BOMUpdateLog(Document):
boms=boms, boms=boms,
timeout=40000, timeout=40000,
now=frappe.flags.in_test, now=frappe.flags.in_test,
enqueue_after_commit=True,
) )
else: else:
frappe.enqueue( frappe.enqueue(
method="erpnext.manufacturing.doctype.bom_update_log.bom_update_log.process_boms_cost_level_wise", method="erpnext.manufacturing.doctype.bom_update_log.bom_update_log.process_boms_cost_level_wise",
update_doc=self, update_doc=self,
now=frappe.flags.in_test, now=frappe.flags.in_test,
enqueue_after_commit=True,
) )

1
erpnext/stock/doctype/item/item.py
View File

@@ -714,6 +714,7 @@ class Item(Document):
template=self, template=self,
now=frappe.flags.in_test, now=frappe.flags.in_test,
timeout=600, timeout=600,
enqueue_after_commit=True,
) )
def validate_has_variants(self): def validate_has_variants(self):

1
erpnext/stock/doctype/stock_settings/stock_settings.py
View File

@@ -93,6 +93,7 @@ class StockSettings(Document):
frappe.enqueue( frappe.enqueue(
"erpnext.stock.doctype.stock_settings.stock_settings.clean_all_descriptions", "erpnext.stock.doctype.stock_settings.stock_settings.clean_all_descriptions",
now=frappe.flags.in_test, now=frappe.flags.in_test,
enqueue_after_commit=True,
) )
def validate_pending_reposts(self): def validate_pending_reposts(self):