diff --git a/CODEOWNERS b/CODEOWNERS index a0c68b87789..50f5b524719 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -8,7 +8,6 @@ erpnext/assets/ @khushi8112 erpnext/regional @ruthra-kumar erpnext/selling @ruthra-kumar erpnext/support/ @ruthra-kumar -pos* @diptanilsaha erpnext/buying/ @rohitwaghchaure @mihir-kandoi erpnext/maintenance/ @rohitwaghchaure diff --git a/erpnext/accounts/doctype/account/chart_of_accounts/chart_of_accounts.py b/erpnext/accounts/doctype/account/chart_of_accounts/chart_of_accounts.py index efb93874226..3513464fa77 100644 --- a/erpnext/accounts/doctype/account/chart_of_accounts/chart_of_accounts.py +++ b/erpnext/accounts/doctype/account/chart_of_accounts/chart_of_accounts.py @@ -18,6 +18,7 @@ def create_charts( accounts = [] def _import_accounts(children, parent, root_type, root_account=False): + nonlocal custom_chart for account_name, child in children.items(): if root_account: root_type = child.get("root_type") @@ -55,7 +56,8 @@ def create_charts( "account_number": account_number, "account_type": child.get("account_type"), "account_currency": child.get("account_currency") - or frappe.get_cached_value("Company", company, "default_currency"), + if custom_chart + else frappe.get_cached_value("Company", company, "default_currency"), "tax_rate": child.get("tax_rate"), } ) diff --git a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py index 7f97c3677bd..3ce867dc96e 100644 --- a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py +++ b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.py @@ -9,7 +9,7 @@ from frappe import _ from frappe.model.document import Document from frappe.query_builder.custom import ConstantColumn from frappe.query_builder.functions import Sum -from frappe.utils import cint, flt +from frappe.utils import cint, create_batch, flt from erpnext import get_default_cost_center from erpnext.accounts.doctype.bank_transaction.bank_transaction import get_total_allocated_amount @@ -377,16 +377,17 @@ def auto_reconcile_vouchers( bank_transactions = get_bank_transactions(bank_account) if len(bank_transactions) > 10: - frappe.enqueue( - method="erpnext.accounts.doctype.bank_reconciliation_tool.bank_reconciliation_tool.start_auto_reconcile", - queue="long", - bank_transactions=bank_transactions, - from_date=from_date, - to_date=to_date, - filter_by_reference_date=filter_by_reference_date, - from_reference_date=from_reference_date, - to_reference_date=to_reference_date, - ) + for bank_transaction_batch in create_batch(bank_transactions, 1000): + frappe.enqueue( + method="erpnext.accounts.doctype.bank_reconciliation_tool.bank_reconciliation_tool.start_auto_reconcile", + queue="long", + bank_transactions=bank_transaction_batch, + from_date=from_date, + to_date=to_date, + filter_by_reference_date=filter_by_reference_date, + from_reference_date=from_reference_date, + to_reference_date=to_reference_date, + ) frappe.msgprint(_("Auto Reconciliation has started in the background")) else: start_auto_reconcile( diff --git a/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js b/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js index 0f01e2dfb65..6412971898c 100644 --- a/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js +++ b/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js @@ -252,7 +252,7 @@ frappe.ui.form.on("Bank Statement Import", { open_url_post(method, { doctype: "Bank Transaction", - export_records: "5_records", + export_records: "blank_template", export_fields: { "Bank Transaction": [ "date", diff --git a/erpnext/accounts/doctype/budget/budget.py b/erpnext/accounts/doctype/budget/budget.py index 7825b2716dc..eec203c6794 100644 --- a/erpnext/accounts/doctype/budget/budget.py +++ b/erpnext/accounts/doctype/budget/budget.py @@ -302,7 +302,7 @@ def compare_expense_with_budget(args, budget_amount, action_for, action, budget_ def get_expense_breakup(args, currency, budget_against): - msg = "
Total Expenses booked through -