From e46736ce357cda4787ca0c96daba9c6749e3f788 Mon Sep 17 00:00:00 2001 From: David Date: Wed, 16 Oct 2024 16:49:07 +0200 Subject: [PATCH] test: don't delete global test records (it's forbidden) --- .../bank_clearance/test_bank_clearance.py | 20 ------------------- .../bank_transaction/test_bank_transaction.py | 13 ------------ .../test_bank_reconciliation_statement.py | 18 ----------------- ...test_opportunity_summary_by_sales_stage.py | 1 - .../test_sales_pipeline_analytics.py | 1 - ...st_payment_terms_status_for_sales_order.py | 7 ------- erpnext/setup/utils.py | 2 -- 7 files changed, 62 deletions(-) diff --git a/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py b/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py index dd25cad2666..087e41b3e5f 100644 --- a/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py +++ b/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py @@ -26,9 +26,6 @@ class TestBankClearance(IntegrationTestCase): create_item("_Test Item") create_cost_center(cost_center_name="_Test Cost Center", company="_Test Company") - clear_payment_entries() - clear_loan_transactions() - clear_pos_sales_invoices() make_bank_account() add_transactions() @@ -123,23 +120,6 @@ class TestBankClearance(IntegrationTestCase): self.assertEqual(si_clearance_date, date) -def clear_payment_entries(): - frappe.db.delete("Payment Entry") - - -def clear_pos_sales_invoices(): - frappe.db.delete("Sales Invoice", {"is_pos": 1}) - - -@if_lending_app_installed -def clear_loan_transactions(): - for dt in [ - "Loan Disbursement", - "Loan Repayment", - ]: - frappe.db.delete(dt) - - def make_bank_account(): if not frappe.db.get_value("Account", "_Test Bank Clearance - _TC"): frappe.get_doc( diff --git a/erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py b/erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py index 6f7f52eb3f6..5bc6d0a8202 100644 --- a/erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py +++ b/erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py @@ -32,14 +32,6 @@ class UnitTestBankTransaction(UnitTestCase): class TestBankTransaction(IntegrationTestCase): def setUp(self): - for dt in [ - "Bank Transaction", - "Payment Entry", - "Payment Entry Reference", - "POS Profile", - ]: - frappe.db.delete(dt) - clear_loan_transactions() make_pos_profile() # generate and use a uniq hash identifier for 'Bank Account' and it's linked GL 'Account' to avoid validation error @@ -231,11 +223,6 @@ class TestBankTransaction(IntegrationTestCase): self.assertEqual(linked_payments[0]["name"], repayment_entry.name) -@if_lending_app_installed -def clear_loan_transactions(): - frappe.db.delete("Loan Repayment") - - def create_bank_account( bank_name="Citi Bank", gl_account="_Test Bank - _TC", bank_account_name="Checking Account" ): diff --git a/erpnext/accounts/report/bank_reconciliation_statement/test_bank_reconciliation_statement.py b/erpnext/accounts/report/bank_reconciliation_statement/test_bank_reconciliation_statement.py index 7002bb6111a..1fed7a43f7d 100644 --- a/erpnext/accounts/report/bank_reconciliation_statement/test_bank_reconciliation_statement.py +++ b/erpnext/accounts/report/bank_reconciliation_statement/test_bank_reconciliation_statement.py @@ -11,15 +11,6 @@ from erpnext.tests.utils import if_lending_app_installed class TestBankReconciliationStatement(IntegrationTestCase): - def setUp(self): - for dt in [ - "Journal Entry", - "Journal Entry Account", - "Payment Entry", - ]: - frappe.db.delete(dt) - clear_loan_transactions() - @if_lending_app_installed def test_loan_entries_in_bank_reco_statement(self): from lending.loan_management.doctype.loan.test_loan import create_loan_accounts @@ -42,12 +33,3 @@ class TestBankReconciliationStatement(IntegrationTestCase): result = execute(filters) self.assertEqual(result[1][0].payment_entry, repayment_entry.name) - - -@if_lending_app_installed -def clear_loan_transactions(): - for dt in [ - "Loan Disbursement", - "Loan Repayment", - ]: - frappe.db.delete(dt) diff --git a/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py b/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py index 1a6ffd5e717..012ac5dc78f 100644 --- a/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py +++ b/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py @@ -16,7 +16,6 @@ from erpnext.crm.report.sales_pipeline_analytics.test_sales_pipeline_analytics i class TestOpportunitySummaryBySalesStage(IntegrationTestCase): @classmethod def setUpClass(self): - frappe.db.delete("Opportunity") create_company() create_customer() create_opportunity() diff --git a/erpnext/crm/report/sales_pipeline_analytics/test_sales_pipeline_analytics.py b/erpnext/crm/report/sales_pipeline_analytics/test_sales_pipeline_analytics.py index 94c3581245a..b29668fa030 100644 --- a/erpnext/crm/report/sales_pipeline_analytics/test_sales_pipeline_analytics.py +++ b/erpnext/crm/report/sales_pipeline_analytics/test_sales_pipeline_analytics.py @@ -8,7 +8,6 @@ from erpnext.crm.report.sales_pipeline_analytics.sales_pipeline_analytics import class TestSalesPipelineAnalytics(IntegrationTestCase): def setUp(self): - frappe.db.delete("Opportunity") create_company() create_customer() create_opportunity() diff --git a/erpnext/selling/report/payment_terms_status_for_sales_order/test_payment_terms_status_for_sales_order.py b/erpnext/selling/report/payment_terms_status_for_sales_order/test_payment_terms_status_for_sales_order.py index 26a854ac4fb..6575cf9ff69 100644 --- a/erpnext/selling/report/payment_terms_status_for_sales_order/test_payment_terms_status_for_sales_order.py +++ b/erpnext/selling/report/payment_terms_status_for_sales_order/test_payment_terms_status_for_sales_order.py @@ -21,16 +21,9 @@ EXTRA_TEST_RECORD_DEPENDENCIES = [ class TestPaymentTermsStatusForSalesOrder(IntegrationTestCase): - def setUp(self): - self.cleanup_old_entries() - def tearDown(self): frappe.db.rollback() - def cleanup_old_entries(self): - frappe.db.delete("Sales Invoice", filters={"company": "_Test Company"}) - frappe.db.delete("Sales Order", filters={"company": "_Test Company"}) - def create_payment_terms_template(self): # create template for 50-50 payments template = None diff --git a/erpnext/setup/utils.py b/erpnext/setup/utils.py index 705fb1f2fcf..13759ff8f58 100644 --- a/erpnext/setup/utils.py +++ b/erpnext/setup/utils.py @@ -36,8 +36,6 @@ def before_tests(): } ) - frappe.db.sql("delete from `tabItem Price`") - _enable_all_roles_for_admin() set_defaults_for_tests()