nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-27 17:04:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent pos opening entry creation for disabled pos profile

Browse Source
This commit is contained in:
diptanilsaha
2025-11-08 12:31:40 +05:30
parent 69016a284f
commit e35e8968f0
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/accounts/doctype/pos_opening_entry/pos_opening_entry.py
View File

@@ -43,9 +43,19 @@ class POSOpeningEntry(StatusUpdater):
self.set_status() self.set_status()
def validate_pos_profile_and_cashier(self): def validate_pos_profile_and_cashier(self):
if self.company != frappe.db.get_value("POS Profile", self.pos_profile, "company"): if not frappe.db.exists("POS Profile", self.pos_profile):
frappe.throw(_("POS Profile {} does not exist.").format(self.pos_profile))
pos_profile_company, pos_profile_disabled = frappe.db.get_value(
"POS Profile", self.pos_profile, ["company", "disabled"]
)
if pos_profile_disabled:
frappe.throw(_("POS Profile {} is disabled.").format(frappe.bold(self.pos_profile)))
if self.company != pos_profile_company:
frappe.throw( frappe.throw(
_("POS Profile {} does not belongs to company {}").format(self.pos_profile, self.company) _("POS Profile {} does not belong to company {}").format(self.pos_profile, self.company)
) )
if not cint(frappe.db.get_value("User", self.user, "enabled")): if not cint(frappe.db.get_value("User", self.user, "enabled")):

6
erpnext/accounts/doctype/pos_opening_entry/test_pos_opening_entry.py
View File

@@ -40,6 +40,12 @@ class TestPOSOpeningEntry(IntegrationTestCase):
self.assertEqual(opening_entry.status, "Open") self.assertEqual(opening_entry.status, "Open")
self.assertNotEqual(opening_entry.docstatus, 0) self.assertNotEqual(opening_entry.docstatus, 0)
def test_pos_opening_entry_on_disabled_pos(self):
test_user, pos_profile = self.init_user_and_profile(disabled=1)
with self.assertRaises(frappe.ValidationError):
create_opening_entry(pos_profile, test_user.name)
def test_multiple_pos_opening_entries_for_same_pos_profile(self): def test_multiple_pos_opening_entries_for_same_pos_profile(self):
test_user, pos_profile = self.init_user_and_profile() test_user, pos_profile = self.init_user_and_profile()
opening_entry = create_opening_entry(pos_profile, test_user.name) opening_entry = create_opening_entry(pos_profile, test_user.name)