nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-28 09:24:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sales_order): replace SQL with ORM in check_nextdoc_docstatus (#55204)

Browse Source
This commit is contained in:
Loic Oberle
2026-05-23 08:04:18 +02:00
committed by GitHub
parent f1c2d2e21d
commit e27b88d789
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/selling/doctype/sales_order/sales_order.py
View File

@@ -577,13 +577,12 @@ class SalesOrder(SellingController):
check_credit_limit(self.customer, self.company) check_credit_limit(self.customer, self.company)
def check_nextdoc_docstatus(self): def check_nextdoc_docstatus(self):
linked_invoices = frappe.db.sql_list( linked_invoices = frappe.get_all(
"""select distinct t1.name "Sales Invoice Item",
from `tabSales Invoice` t1,`tabSales Invoice Item` t2 filters={"sales_order": self.name, "docstatus": 0},
where t1.name = t2.parent and t2.sales_order = %s and t1.docstatus = 0""", pluck="parent",
self.name, distinct=True,
) )
if linked_invoices: if linked_invoices:
linked_invoices = [get_link_to_form("Sales Invoice", si) for si in linked_invoices] linked_invoices = [get_link_to_form("Sales Invoice", si) for si in linked_invoices]
frappe.throw( frappe.throw(