From e2787cf2ec1855c84d0f571132a6092451a20278 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Mon, 25 May 2015 15:27:40 +0530 Subject: [PATCH] [fix] unique employee id validation for sales person --- erpnext/setup/doctype/sales_person/sales_person.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/erpnext/setup/doctype/sales_person/sales_person.py b/erpnext/setup/doctype/sales_person/sales_person.py index 5f70b233356..21a86cf58dd 100644 --- a/erpnext/setup/doctype/sales_person/sales_person.py +++ b/erpnext/setup/doctype/sales_person/sales_person.py @@ -29,5 +29,7 @@ class SalesPerson(NestedSet): return frappe.db.get_value("User", user, "email") or user def validate_employee_id(self): - if frappe.db.exists({"doctype": "Sales Person","employee": self.employee}): - frappe.throw("Another sales person with the same employee id exists.", frappe.DuplicateEntryError) + sales_person = frappe.db.get_value("Sales Person", {"employee": self.employee}) + + if sales_person and sales_person != self.name: + frappe.throw(_("Another sales person {0} exists with the same employee id").format(sales_person))