nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-05 06:28:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #17413 from rohitwaghchaure/duplicate_error_if_project_created_from_so

Browse Source 
hotfix: while making project from sales order, getting duplicate project error
This commit is contained in:
rohitwaghchaure
2019-04-29 22:21:18 +05:30
committed by GitHub
parent f6a9eec23a cefef3b62d
commit e1df414f8b
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/projects/doctype/project/project.py
View File

@@ -74,7 +74,7 @@ class Project(Document):
self.load_tasks() self.load_tasks()
self.validate_dates() self.validate_dates()
self.send_welcome_email() self.send_welcome_email()
self.update_percent_complete() self.update_percent_complete(from_validate=True)
def validate_project_name(self): def validate_project_name(self):
if self.get("__islocal") and frappe.db.exists("Project", self.project_name): if self.get("__islocal") and frappe.db.exists("Project", self.project_name):
@@ -198,7 +198,7 @@ class Project(Document):
if self.sales_order: if self.sales_order:
frappe.db.set_value("Sales Order", self.sales_order, "project", self.name) frappe.db.set_value("Sales Order", self.sales_order, "project", self.name)
def update_percent_complete(self): def update_percent_complete(self, from_validate=False):
if not self.tasks: return if not self.tasks: return
total = frappe.db.sql("""select count(name) from tabTask where project=%s""", self.name)[0][0] total = frappe.db.sql("""select count(name) from tabTask where project=%s""", self.name)[0][0]
if not total and self.percent_complete: if not total and self.percent_complete:
@@ -227,7 +227,9 @@ class Project(Document):
self.status = "Completed" self.status = "Completed"
elif not self.status == "Cancelled": elif not self.status == "Cancelled":
self.status = "Open" self.status = "Open"
self.db_update()
if not from_validate:
self.db_update()
def update_costing(self): def update_costing(self):
from_time_sheet = frappe.db.sql("""select from_time_sheet = frappe.db.sql("""select