From e18be9b21e7905ab4c8eb3d3be94ea3010b821c5 Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Tue, 14 May 2024 17:56:06 +0530 Subject: [PATCH] fix: Asset cancelation issue (cherry picked from commit fa2b6c4490015a4c36e354f5702aed0e5974b228) --- erpnext/accounts/doctype/journal_entry/journal_entry.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.py b/erpnext/accounts/doctype/journal_entry/journal_entry.py index 4de20a17389..eea4698228d 100644 --- a/erpnext/accounts/doctype/journal_entry/journal_entry.py +++ b/erpnext/accounts/doctype/journal_entry/journal_entry.py @@ -450,11 +450,12 @@ class JournalEntry(AccountsController): def unlink_asset_reference(self): for d in self.get("accounts"): + root_type = frappe.get_value("Account", d.account, "root_type") if ( self.voucher_type == "Depreciation Entry" and d.reference_type == "Asset" and d.reference_name - and d.account_type == "Depreciation" + and root_type == "Expense" and d.debit ): asset = frappe.get_doc("Asset", d.reference_name)