mirror of
https://github.com/frappe/erpnext.git
synced 2026-05-24 23:49:19 +00:00
perf: remove unnecessary branching and use cache in get_item_warehouse
This commit is contained in:
@@ -585,20 +585,12 @@ def get_item_warehouse_(ctx: ItemDetailsCtx, item, overwrite_warehouse, defaults
|
|||||||
or ctx.warehouse
|
or ctx.warehouse
|
||||||
)
|
)
|
||||||
|
|
||||||
if not warehouse:
|
|
||||||
defaults = frappe.defaults.get_defaults() or {}
|
|
||||||
warehouse_exists = frappe.db.exists(
|
|
||||||
"Warehouse", {"name": defaults.default_warehouse, "company": ctx.company}
|
|
||||||
)
|
|
||||||
if defaults.get("default_warehouse") and warehouse_exists:
|
|
||||||
warehouse = defaults.default_warehouse
|
|
||||||
|
|
||||||
else:
|
else:
|
||||||
warehouse = ctx.warehouse
|
warehouse = ctx.warehouse
|
||||||
|
|
||||||
if not warehouse:
|
if not warehouse:
|
||||||
default_warehouse = frappe.get_single_value("Stock Settings", "default_warehouse")
|
default_warehouse = frappe.get_single_value("Stock Settings", "default_warehouse")
|
||||||
if frappe.db.get_value("Warehouse", default_warehouse, "company") == ctx.company:
|
if frappe.get_cached_value("Warehouse", default_warehouse, "company") == ctx.company:
|
||||||
return default_warehouse
|
return default_warehouse
|
||||||
|
|
||||||
return warehouse
|
return warehouse
|
||||||
|
|||||||
Reference in New Issue
Block a user