From e11cadca585fa89712ab1d17e4be85226b290d8a Mon Sep 17 00:00:00 2001 From: Sagar Vora <16315650+sagarvora@users.noreply.github.com> Date: Tue, 12 Aug 2025 16:16:24 +0530 Subject: [PATCH] perf: remove unnecessary branching and use cache in `get_item_warehouse` --- erpnext/stock/get_item_details.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/erpnext/stock/get_item_details.py b/erpnext/stock/get_item_details.py index b3b37277791..842c31e35ba 100644 --- a/erpnext/stock/get_item_details.py +++ b/erpnext/stock/get_item_details.py @@ -585,20 +585,12 @@ def get_item_warehouse_(ctx: ItemDetailsCtx, item, overwrite_warehouse, defaults or ctx.warehouse ) - if not warehouse: - defaults = frappe.defaults.get_defaults() or {} - warehouse_exists = frappe.db.exists( - "Warehouse", {"name": defaults.default_warehouse, "company": ctx.company} - ) - if defaults.get("default_warehouse") and warehouse_exists: - warehouse = defaults.default_warehouse - else: warehouse = ctx.warehouse if not warehouse: default_warehouse = frappe.get_single_value("Stock Settings", "default_warehouse") - if frappe.db.get_value("Warehouse", default_warehouse, "company") == ctx.company: + if frappe.get_cached_value("Warehouse", default_warehouse, "company") == ctx.company: return default_warehouse return warehouse