perf: remove unnecessary branching and use cache in get_item_warehouse

This commit is contained in:
Sagar Vora
2025-08-12 16:16:24 +05:30
parent 81c8972a66
commit e11cadca58

View File

@@ -585,20 +585,12 @@ def get_item_warehouse_(ctx: ItemDetailsCtx, item, overwrite_warehouse, defaults
or ctx.warehouse
)
if not warehouse:
defaults = frappe.defaults.get_defaults() or {}
warehouse_exists = frappe.db.exists(
"Warehouse", {"name": defaults.default_warehouse, "company": ctx.company}
)
if defaults.get("default_warehouse") and warehouse_exists:
warehouse = defaults.default_warehouse
else:
warehouse = ctx.warehouse
if not warehouse:
default_warehouse = frappe.get_single_value("Stock Settings", "default_warehouse")
if frappe.db.get_value("Warehouse", default_warehouse, "company") == ctx.company:
if frappe.get_cached_value("Warehouse", default_warehouse, "company") == ctx.company:
return default_warehouse
return warehouse