From dfb64d7635f07f8793980e4ebc53934829bfec5b Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 3 Sep 2026 15:07:48 +0530 Subject: [PATCH] fix(setup): strict permissions for transaction deletion record (backport #58687) (#58723) Co-authored-by: Diptanil Saha --- erpnext/setup/doctype/company/company.py | 3 +++ .../transaction_deletion_record.json | 9 ++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/erpnext/setup/doctype/company/company.py b/erpnext/setup/doctype/company/company.py index d481bcb0ab1..9ca38e706ed 100644 --- a/erpnext/setup/doctype/company/company.py +++ b/erpnext/setup/doctype/company/company.py @@ -1082,6 +1082,8 @@ def get_billing_shipping_address(name, billing_address=None, shipping_address=No @frappe.whitelist() def create_transaction_deletion_request(company): frappe.only_for("System Manager") + # User Permission check + frappe.has_permission("Company", ptype="delete", doc=company, throw=True) from erpnext.setup.doctype.transaction_deletion_record.transaction_deletion_record import ( is_deletion_doc_running, @@ -1090,6 +1092,7 @@ def create_transaction_deletion_request(company): is_deletion_doc_running(company) tdr = frappe.get_doc({"doctype": "Transaction Deletion Record", "company": company}) + tdr.flags.ignore_permissions = 1 tdr.insert() tdr.generate_to_delete_list() diff --git a/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.json b/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.json index f309139bb5d..7c718f098c4 100644 --- a/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.json +++ b/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.json @@ -1,5 +1,6 @@ { "actions": [], + "allow_bulk_edit": 1, "autoname": "TDL.####", "creation": "2021-04-06 20:17:18.404716", "doctype": "DocType", @@ -166,19 +167,18 @@ "read_only": 1 } ], + "in_create": 1, "index_web_pages_for_search": 1, "is_submittable": 1, "links": [], - "modified": "2025-11-18 15:02:46.427695", + "modified": "2026-09-02 20:32:19.679290", "modified_by": "Administrator", "module": "Setup", "name": "Transaction Deletion Record", - "naming_rule": "Expression (old style)", + "naming_rule": "Expression", "owner": "Administrator", "permissions": [ { - "create": 1, - "delete": 1, "email": 1, "export": 1, "print": 1, @@ -186,7 +186,6 @@ "report": 1, "role": "System Manager", "share": 1, - "submit": 1, "write": 1 } ],