fix: resolved conflict

(cherry picked from commit c085b6159b)
This commit is contained in:
Khushi Rawat
2024-08-14 00:03:35 +05:30
committed by Mergify
parent 8624a0abce
commit defd5541b0
4 changed files with 30 additions and 7 deletions

View File

@@ -509,7 +509,10 @@ class AssetDepreciationSchedule(Document):
continue continue
if not accumulated_depreciation: if not accumulated_depreciation:
if i > 0 and asset_doc.flags.decrease_in_asset_value_due_to_value_adjustment: if i > 0 and (
asset_doc.flags.decrease_in_asset_value_due_to_value_adjustment
or asset_doc.flags.increase_in_asset_value_due_to_repair
):
accumulated_depreciation = self.get("depreciation_schedule")[ accumulated_depreciation = self.get("depreciation_schedule")[
i - 1 i - 1
].accumulated_depreciation_amount ].accumulated_depreciation_amount
@@ -677,7 +680,7 @@ def get_straight_line_or_manual_depr_amount(
# if the Depreciation Schedule is being modified after Asset Repair due to increase in asset value # if the Depreciation Schedule is being modified after Asset Repair due to increase in asset value
elif asset.flags.increase_in_asset_value_due_to_repair: elif asset.flags.increase_in_asset_value_due_to_repair:
return (flt(row.value_after_depreciation) - flt(row.expected_value_after_useful_life)) / flt( return (flt(row.value_after_depreciation) - flt(row.expected_value_after_useful_life)) / flt(
row.total_number_of_depreciations number_of_pending_depreciations
) )
# if the Depreciation Schedule is being modified after Asset Value Adjustment due to decrease in asset value # if the Depreciation Schedule is being modified after Asset Value Adjustment due to decrease in asset value
elif asset.flags.decrease_in_asset_value_due_to_value_adjustment: elif asset.flags.decrease_in_asset_value_due_to_value_adjustment:
@@ -1041,6 +1044,7 @@ def make_new_active_asset_depr_schedules_and_cancel_current_ones(
date_of_return=None, date_of_return=None,
value_after_depreciation=None, value_after_depreciation=None,
ignore_booked_entry=False, ignore_booked_entry=False,
difference_amount=None,
): ):
for row in asset_doc.get("finance_books"): for row in asset_doc.get("finance_books"):
current_asset_depr_schedule_doc = get_asset_depr_schedule_doc( current_asset_depr_schedule_doc = get_asset_depr_schedule_doc(
@@ -1055,6 +1059,8 @@ def make_new_active_asset_depr_schedules_and_cancel_current_ones(
) )
new_asset_depr_schedule_doc = frappe.copy_doc(current_asset_depr_schedule_doc) new_asset_depr_schedule_doc = frappe.copy_doc(current_asset_depr_schedule_doc)
if asset_doc.flags.decrease_in_asset_value_due_to_value_adjustment and not value_after_depreciation:
value_after_depreciation = row.value_after_depreciation + difference_amount
if asset_doc.flags.increase_in_asset_value_due_to_repair and row.depreciation_method in ( if asset_doc.flags.increase_in_asset_value_due_to_repair and row.depreciation_method in (
"Written Down Value", "Written Down Value",

View File

@@ -29,6 +29,15 @@ frappe.ui.form.on("Asset Repair", {
}; };
}); });
frm.set_query("purchase_invoice", function () {
return {
filters: {
company: frm.doc.company,
docstatus: 1,
},
};
});
frm.set_query("warehouse", "stock_items", function () { frm.set_query("warehouse", "stock_items", function () {
return { return {
filters: { filters: {

View File

@@ -117,7 +117,9 @@ class AssetRepair(AccountsController):
get_link_to_form(self.doctype, self.name), get_link_to_form(self.doctype, self.name),
) )
self.asset_doc.flags.ignore_validate_update_after_submit = True self.asset_doc.flags.ignore_validate_update_after_submit = True
make_new_active_asset_depr_schedules_and_cancel_current_ones(self.asset_doc, notes) make_new_active_asset_depr_schedules_and_cancel_current_ones(
self.asset_doc, notes, ignore_booked_entry=True
)
self.asset_doc.save() self.asset_doc.save()
add_asset_activity( add_asset_activity(
@@ -154,7 +156,9 @@ class AssetRepair(AccountsController):
get_link_to_form(self.doctype, self.name), get_link_to_form(self.doctype, self.name),
) )
self.asset_doc.flags.ignore_validate_update_after_submit = True self.asset_doc.flags.ignore_validate_update_after_submit = True
make_new_active_asset_depr_schedules_and_cancel_current_ones(self.asset_doc, notes) make_new_active_asset_depr_schedules_and_cancel_current_ones(
self.asset_doc, notes, ignore_booked_entry=True
)
self.asset_doc.save() self.asset_doc.save()
add_asset_activity( add_asset_activity(

View File

@@ -57,7 +57,7 @@ class AssetValueAdjustment(Document):
def on_cancel(self): def on_cancel(self):
frappe.get_doc("Journal Entry", self.journal_entry).cancel() frappe.get_doc("Journal Entry", self.journal_entry).cancel()
self.update_asset(self.current_asset_value) self.update_asset()
add_asset_activity( add_asset_activity(
self.asset, self.asset,
_("Asset's value adjusted after cancellation of Asset Value Adjustment {0}").format( _("Asset's value adjusted after cancellation of Asset Value Adjustment {0}").format(
@@ -145,7 +145,7 @@ class AssetValueAdjustment(Document):
self.db_set("journal_entry", je.name) self.db_set("journal_entry", je.name)
def update_asset(self, asset_value): def update_asset(self, asset_value=None):
asset = frappe.get_doc("Asset", self.asset) asset = frappe.get_doc("Asset", self.asset)
if not asset.calculate_depreciation: if not asset.calculate_depreciation:
@@ -171,7 +171,11 @@ class AssetValueAdjustment(Document):
) )
make_new_active_asset_depr_schedules_and_cancel_current_ones( make_new_active_asset_depr_schedules_and_cancel_current_ones(
asset, notes, value_after_depreciation=asset_value, ignore_booked_entry=True asset,
notes,
value_after_depreciation=asset_value,
ignore_booked_entry=True,
difference_amount=self.difference_amount,
) )
asset.flags.ignore_validate_update_after_submit = True asset.flags.ignore_validate_update_after_submit = True
asset.save() asset.save()