nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-01 11:19:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: speed up customer import (#47738)

Browse Source 
* perf: Avoid fetching customer from DB

This is likely code from bygone era where is_new and doc_before_save didn't exist?

I see no reason to do it in this weird manner. This code still appears
to be wrong but I'll leave it as is for now.

* fix: don't validate internal customer for non-internal customer

This was likely missed out while adding validations
This commit is contained in:
Ankush Menat
2025-05-26 17:05:34 +05:30
committed by GitHub
parent ff59b89f3e
commit def9d8c9e0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/selling/doctype/customer/customer.py
View File

@@ -152,8 +152,7 @@ class Customer(TransactionBase):
self.validate_currency_for_receivable_payable_and_advance_account() self.validate_currency_for_receivable_payable_and_advance_account()
# set loyalty program tier # set loyalty program tier
if frappe.db.exists("Customer", self.name): if not self.is_new() and (customer := self.get_doc_before_save()):
customer = frappe.get_doc("Customer", self.name)
if self.loyalty_program == customer.loyalty_program and not self.loyalty_program_tier: if self.loyalty_program == customer.loyalty_program and not self.loyalty_program_tier:
self.loyalty_program_tier = customer.loyalty_program_tier self.loyalty_program_tier = customer.loyalty_program_tier
@@ -207,6 +206,7 @@ class Customer(TransactionBase):
def validate_internal_customer(self): def validate_internal_customer(self):
if not self.is_internal_customer: if not self.is_internal_customer:
self.represents_company = "" self.represents_company = ""
return
internal_customer = frappe.db.get_value( internal_customer = frappe.db.get_value(
"Customer", "Customer",