From de85f243830c64a3b1fe20d440b4d913ad5380eb Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Wed, 1 Aug 2018 15:57:13 +0530 Subject: [PATCH] Rename base_page to subpage --- erpnext/public/js/hub/pages/category.js | 2 +- erpnext/public/js/hub/pages/favourites.js | 2 +- erpnext/public/js/hub/pages/home.js | 2 +- erpnext/public/js/hub/pages/not_found.js | 2 +- erpnext/public/js/hub/pages/profile.js | 2 +- erpnext/public/js/hub/pages/publish.js | 2 +- erpnext/public/js/hub/pages/published_products.js | 2 +- erpnext/public/js/hub/pages/register.js | 2 +- erpnext/public/js/hub/pages/search.js | 2 +- .../public/js/hub/pages/{base_page.js => subpage.js} | 10 ++++++++++ 10 files changed, 19 insertions(+), 9 deletions(-) rename erpnext/public/js/hub/pages/{base_page.js => subpage.js} (74%) diff --git a/erpnext/public/js/hub/pages/category.js b/erpnext/public/js/hub/pages/category.js index 21dcb328fd7..de1281cd18c 100644 --- a/erpnext/public/js/hub/pages/category.js +++ b/erpnext/public/js/hub/pages/category.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; import { get_item_card_container_html } from '../helpers'; erpnext.hub.Category = class Category extends SubPage { diff --git a/erpnext/public/js/hub/pages/favourites.js b/erpnext/public/js/hub/pages/favourites.js index 9605eb19b03..704caeabbb4 100644 --- a/erpnext/public/js/hub/pages/favourites.js +++ b/erpnext/public/js/hub/pages/favourites.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; import { get_item_card_container_html } from '../helpers'; erpnext.hub.Favourites = class Favourites extends SubPage { diff --git a/erpnext/public/js/hub/pages/home.js b/erpnext/public/js/hub/pages/home.js index ff37e812c33..6a49f6265b4 100644 --- a/erpnext/public/js/hub/pages/home.js +++ b/erpnext/public/js/hub/pages/home.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; import { make_search_bar, get_item_card_container_html } from '../helpers'; erpnext.hub.Home = class Home extends SubPage { diff --git a/erpnext/public/js/hub/pages/not_found.js b/erpnext/public/js/hub/pages/not_found.js index a83d8817dee..3b864464f3d 100644 --- a/erpnext/public/js/hub/pages/not_found.js +++ b/erpnext/public/js/hub/pages/not_found.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; erpnext.hub.NotFound = class NotFound extends SubPage { refresh() { diff --git a/erpnext/public/js/hub/pages/profile.js b/erpnext/public/js/hub/pages/profile.js index 6dd1f8716a2..a38cde4276d 100644 --- a/erpnext/public/js/hub/pages/profile.js +++ b/erpnext/public/js/hub/pages/profile.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; erpnext.hub.Profile = class Profile extends SubPage { make_wrapper() { diff --git a/erpnext/public/js/hub/pages/publish.js b/erpnext/public/js/hub/pages/publish.js index 6e8caabb4ce..2bcc0c6e45e 100644 --- a/erpnext/public/js/hub/pages/publish.js +++ b/erpnext/public/js/hub/pages/publish.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; import { make_search_bar, get_item_card_container_html, get_local_item_card_html } from '../helpers'; erpnext.hub.Publish = class Publish extends SubPage { diff --git a/erpnext/public/js/hub/pages/published_products.js b/erpnext/public/js/hub/pages/published_products.js index f21c6fa7ffb..11cce4d9494 100644 --- a/erpnext/public/js/hub/pages/published_products.js +++ b/erpnext/public/js/hub/pages/published_products.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; import { get_item_card_container_html } from '../helpers'; erpnext.hub.PublishedProducts = class PublishedProducts extends SubPage { diff --git a/erpnext/public/js/hub/pages/register.js b/erpnext/public/js/hub/pages/register.js index d8966f12a1f..b95ec044446 100644 --- a/erpnext/public/js/hub/pages/register.js +++ b/erpnext/public/js/hub/pages/register.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; erpnext.hub.Register = class Register extends SubPage { make_wrapper() { diff --git a/erpnext/public/js/hub/pages/search.js b/erpnext/public/js/hub/pages/search.js index 276c9bc6682..dbaecba2267 100644 --- a/erpnext/public/js/hub/pages/search.js +++ b/erpnext/public/js/hub/pages/search.js @@ -1,4 +1,4 @@ -import SubPage from './base_page'; +import SubPage from './subpage'; import { make_search_bar, get_item_card_container_html } from '../helpers'; erpnext.hub.SearchPage = class SearchPage extends SubPage { diff --git a/erpnext/public/js/hub/pages/base_page.js b/erpnext/public/js/hub/pages/subpage.js similarity index 74% rename from erpnext/public/js/hub/pages/base_page.js rename to erpnext/public/js/hub/pages/subpage.js index 70248da3665..a030e7e33bc 100644 --- a/erpnext/public/js/hub/pages/base_page.js +++ b/erpnext/public/js/hub/pages/subpage.js @@ -3,6 +3,16 @@ export default class SubPage { this.$parent = $(parent); this.make_wrapper(options); + // generic action handler + this.$wrapper.on('click', '[data-action]', e => { + const $this = $(e.currentTarget); + const action = $this.data().action; + + if (action && this[action]) { + this[action].apply(this); + } + }) + // handle broken images after every render if (this.render) { this._render = this.render.bind(this);