nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-02 08:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(manufacture): preserve user-entered rate for secondary items with zero cost allocation

Browse Source 
When a BOM secondary item has cost_allocation_per = 0 (the default), the
previous code unconditionally computed `0 / transfer_qty = 0`, wiping any
rate the user had entered for the item. Now the allocation formula only runs
when cost_allocation_per > 0, allowing the valuation-rate fallback (or a
manually entered rate) to apply instead.

Additionally, secondary items with transfer_qty = 0 now short-circuit the
entire rate pipeline: they get rate = 0 and amount = 0 immediately, avoiding
a ZeroDivisionError and the spurious "enter basic rate" prompt.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Umair Sayed
2026-06-12 16:04:12 +05:30
parent 6771daf6a1
commit de3df6bcef
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/stock/doctype/stock_entry/stock_entry.py
View File

@@ -554,6 +554,13 @@ class StockEntry(StockController, SubcontractingInwardController):
for d in self.get("items"): for d in self.get("items"):
if d.s_warehouse or d.set_basic_rate_manually: if d.s_warehouse or d.set_basic_rate_manually:
continue continue
# Zero-qty secondary items carry no inventory value; skip rate calculation
if d.secondary_item_type and flt(d.transfer_qty) == 0:
d.basic_rate = 0.0
d.basic_amount = 0.0
continue
self._set_incoming_item_rate(d, outgoing_items_cost, raise_error_if_no_rate, zero_valuation_items) self._set_incoming_item_rate(d, outgoing_items_cost, raise_error_if_no_rate, zero_valuation_items)
if zero_valuation_items: if zero_valuation_items:
@@ -575,7 +582,10 @@ class StockEntry(StockController, SubcontractingInwardController):
cost_allocation_per = frappe.get_value( cost_allocation_per = frappe.get_value(
"BOM Secondary Item", d.bom_secondary_item, "cost_allocation_per" "BOM Secondary Item", d.bom_secondary_item, "cost_allocation_per"
) )
d.basic_rate = (outgoing_items_cost * (cost_allocation_per / 100)) / d.transfer_qty # Only recalculate when cost is actually allocated; otherwise preserve the
# user-entered rate (or fall through to get_valuation_rate below)
if cost_allocation_per and flt(d.transfer_qty):
d.basic_rate = (outgoing_items_cost * (cost_allocation_per / 100)) / d.transfer_qty
if not d.basic_rate and not d.allow_zero_valuation_rate: if not d.basic_rate and not d.allow_zero_valuation_rate:
d.basic_rate = get_valuation_rate( d.basic_rate = get_valuation_rate(