From de17367a367681ebf124fccadaf184dbb523ee7d Mon Sep 17 00:00:00 2001 From: anandbaburajan Date: Thu, 24 Nov 2022 16:16:36 +0530 Subject: [PATCH] chore: finish refactoring asset_value_adjustment --- .../asset_value_adjustment/asset_value_adjustment.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py b/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py index bba61e646e1..b6c4a3d2109 100644 --- a/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py +++ b/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py @@ -117,7 +117,6 @@ class AssetValueAdjustment(Document): d.value_after_depreciation = asset_value current_asset_depr_schedule = get_asset_depr_schedule(asset.name, d.finance_book) - current_asset_depr_schedule_doc = frappe.get_doc( "Asset Depreciation Schedule", current_asset_depr_schedule ) @@ -125,6 +124,10 @@ class AssetValueAdjustment(Document): new_asset_depr_schedule_doc = frappe.copy_doc( current_asset_depr_schedule_doc, ignore_no_copy=False ) + new_asset_depr_schedule_doc.notes = "Asset value adjustment" + + current_asset_depr_schedule_doc.cancel() + new_asset_depr_schedule_doc.insert() depr_schedule = new_asset_depr_schedule_doc.get("depreciation_schedule") @@ -157,10 +160,6 @@ class AssetValueAdjustment(Document): if not asset_data.journal_entry: asset_data.db_update() - current_asset_depr_schedule_doc.cancel() - - new_asset_depr_schedule_doc.notes = "Asset value adjustment" - new_asset_depr_schedule_doc.submit()