From ddc9ea16cc263bd4b7bef472642f9ea2e4fb7d26 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 23 Apr 2026 13:29:15 +0000 Subject: [PATCH] ci: test correctness pattern (backport #54186) (#54473) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> --- semgrep/test-correctness.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/semgrep/test-correctness.yml b/semgrep/test-correctness.yml index 34eb82fa1d6..90a32af93e9 100644 --- a/semgrep/test-correctness.yml +++ b/semgrep/test-correctness.yml @@ -10,9 +10,15 @@ rules: languages: [python] severity: ERROR - id: Dont-override-teardown - pattern: | - def tearDown(...): - ... + patterns: + - pattern: | + def tearDown(...): + ... + - pattern-not: | + def tearDown(...): + ... + super().tearDown() + ... message: ERPNextTestSuite forces rollback on each tearDown, which ensures idempotency. Don't override tearDown. languages: [python] severity: ERROR