nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-23 15:09:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: validate_packed_qty()

Browse Source 
(cherry picked from commit 699532647d)
This commit is contained in:
s-aga-r
2023-04-28 23:03:33 +05:30
committed by Mergify
parent 7105648468
commit dd7e5e019f
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/stock/doctype/delivery_note/delivery_note.py
View File

@@ -303,20 +303,13 @@ class DeliveryNote(SellingController):
) )
def validate_packed_qty(self): def validate_packed_qty(self):
""" """Validate that if packed qty exists, it should be equal to qty"""
Validate that if packed qty exists, it should be equal to qty
""" for item in self.items + self.packed_items:
if not any(flt(d.get("packed_qty")) for d in self.get("items")): if item.packed_qty and item.packed_qty != item.qty:
return frappe.throw(
has_error = False _("Row {0}: Packed Qty must be equal to {1} Qty.").format(item.idx, frappe.bold(item.doctype))
for d in self.get("items"):
if flt(d.get("qty")) != flt(d.get("packed_qty")):
frappe.msgprint(
_("Packed quantity must equal quantity for Item {0} in row {1}").format(d.item_code, d.idx)
) )
has_error = True
if has_error:
raise frappe.ValidationError
def update_pick_list_status(self): def update_pick_list_status(self):
from erpnext.stock.doctype.pick_list.pick_list import update_pick_list_status from erpnext.stock.doctype.pick_list.pick_list import update_pick_list_status