Merge pull request #56624 from mihir-kandoi/pg-ci-fanout-stop-guard

ci(postgres): fail setup if pg_ctl stop fails; drop redundant ALTER SYSTEM block
This commit is contained in:
Mihir Kandoi
2026-06-29 22:10:52 +05:30
committed by GitHub
2 changed files with 9 additions and 9 deletions

View File

@@ -108,7 +108,11 @@ jobs:
- name: Stop DB and stage datadir
run: |
PG_BIN=$(ls -d /usr/lib/postgresql/*/bin | sort -V | tail -1)
"$PG_BIN/pg_ctl" -D /home/runner/pgdata -m fast -w stop || true
# Clean shutdown so the baked datadir is consistent. Do NOT swallow a failed stop with
# `|| true`: moving and tarring a still-running cluster ships a torn datadir the shards
# cannot crash-recover (full_page_writes is off). Fail the job instead — mirrors the
# MariaDB sister's "don't bake a dirty datadir" guard.
"$PG_BIN/pg_ctl" -D /home/runner/pgdata -m fast -w stop
mv /home/runner/pgdata /home/runner/frappe-bench/pgdata
- name: Package bench for test shards