From db9ce998e11cabe50f2a190a96bdad90ce162848 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Fri, 26 Dec 2025 17:33:09 +0530 Subject: [PATCH] test: remove invalid test case --- .../test_supplier_scorecard_criteria.py | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/erpnext/buying/doctype/supplier_scorecard_criteria/test_supplier_scorecard_criteria.py b/erpnext/buying/doctype/supplier_scorecard_criteria/test_supplier_scorecard_criteria.py index 7b98d6d23c0..114ff2b56b3 100644 --- a/erpnext/buying/doctype/supplier_scorecard_criteria/test_supplier_scorecard_criteria.py +++ b/erpnext/buying/doctype/supplier_scorecard_criteria/test_supplier_scorecard_criteria.py @@ -17,7 +17,6 @@ class TestSupplierScorecardCriteria(IntegrationTestCase): def test_formula_validate(self): delete_test_scorecards() self.assertRaises(frappe.ValidationError, frappe.get_doc(test_bad_criteria[1]).insert) - self.assertRaises(frappe.ValidationError, frappe.get_doc(test_bad_criteria[2]).insert) def delete_test_scorecards(): @@ -68,16 +67,8 @@ test_bad_criteria = [ "name": "Fake Criteria 2", "weight": 40.0, "doctype": "Supplier Scorecard Criteria", - "formula": "(({cost_of_on_time_shipments} / {tot_cost_shipments}))* 100", # Force 0 divided by 0 + "formula": "(({cost_of_on_time_shipments} {cost_of_on_time_shipments} / {tot_cost_shipments}))* 100", # Two variables beside eachother "criteria_name": "Fake Criteria 2", "max_score": 100.0, }, - { - "name": "Fake Criteria 3", - "weight": 40.0, - "doctype": "Supplier Scorecard Criteria", - "formula": "(({cost_of_on_time_shipments} {cost_of_on_time_shipments} / {tot_cost_shipments}))* 100", # Two variables beside eachother - "criteria_name": "Fake Criteria 3", - "max_score": 100.0, - }, ]