From d9d8fc69126b5e6295191ab84d3646611b6390b7 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Fri, 17 Apr 2026 15:14:17 +0530 Subject: [PATCH] fix: move make_dimension_in_accounting_doctypes from after_insert to on_update (backport #54172) (#54317) * fix: move make_dimension_in_accounting_doctypes from after_insert to on_update (cherry picked from commit ee067e6015909a27462a5e6a0093a22a45c03820) # Conflicts: # erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py * chore: resolve conflicts in accounting_dimension.py --------- Co-authored-by: Shllokkk --- .../doctype/accounting_dimension/accounting_dimension.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py b/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py index 02019943c25..f654ccd3db0 100644 --- a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py +++ b/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py @@ -82,13 +82,15 @@ class AccountingDimension(Document): else: frappe.throw(_("Company {0} is added more than once").format(frappe.bold(default.company))) - def after_insert(self): + def on_update(self): if frappe.flags.in_test: make_dimension_in_accounting_doctypes(doc=self) else: frappe.enqueue( make_dimension_in_accounting_doctypes, doc=self, queue="long", enqueue_after_commit=True ) + frappe.flags.accounting_dimensions = None + frappe.flags.accounting_dimensions_details = None def on_trash(self): if frappe.flags.in_test: @@ -103,10 +105,6 @@ class AccountingDimension(Document): if not self.fieldname: self.fieldname = scrub(self.label) - def on_update(self): - frappe.flags.accounting_dimensions = None - frappe.flags.accounting_dimensions_details = None - def make_dimension_in_accounting_doctypes(doc, doclist=None): if not doclist: