nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-31 07:28:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: parse native JSON request args in controllers/item_variant.py

Browse Source 
Use frappe.parse_json instead of json.loads so the whitelisted endpoints
accept native JSON types (list/dict/bool) in addition to JSON strings.
This commit is contained in:
Mihir Kandoi
2026-06-24 20:37:32 +05:30
parent 1cf5cb2425
commit d8ff9b7dbb
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/controllers/item_variant.py
View File

@@ -45,8 +45,7 @@ def get_variant(
if item_template.variant_based_on == "Manufacturer" and manufacturer: if item_template.variant_based_on == "Manufacturer" and manufacturer:
return make_variant_based_on_manufacturer(item_template, manufacturer, manufacturer_part_no) return make_variant_based_on_manufacturer(item_template, manufacturer, manufacturer_part_no)
if isinstance(args, str): args = frappe.parse_json(args)
args = json.loads(args)
attribute_args = {k: v for k, v in args.items() if k != "use_template_image"} attribute_args = {k: v for k, v in args.items() if k != "use_template_image"}
if not attribute_args: if not attribute_args:
@@ -258,8 +257,7 @@ def find_variant(template, args, variant_item_code=None):
@frappe.whitelist() @frappe.whitelist()
def create_variant(item: str, args: dict | str, use_template_image: bool = False): def create_variant(item: str, args: dict | str, use_template_image: bool = False):
use_template_image = frappe.parse_json(use_template_image) use_template_image = frappe.parse_json(use_template_image)
if isinstance(args, str): args = frappe.parse_json(args)
args = json.loads(args)
template = frappe.get_doc("Item", item) template = frappe.get_doc("Item", item)
variant = frappe.new_doc("Item") variant = frappe.new_doc("Item")
@@ -286,10 +284,7 @@ def create_variant(item: str, args: dict | str, use_template_image: bool = False
def enqueue_multiple_variant_creation(item: str, args: dict | str, use_template_image: bool = False): def enqueue_multiple_variant_creation(item: str, args: dict | str, use_template_image: bool = False):
use_template_image = frappe.parse_json(use_template_image) use_template_image = frappe.parse_json(use_template_image)
# There can be innumerable attribute combinations, enqueue # There can be innumerable attribute combinations, enqueue
if isinstance(args, str): variants = frappe.parse_json(args)
variants = json.loads(args)
else:
variants = args
variants = {key: values for key, values in variants.items() if values} variants = {key: values for key, values in variants.items() if values}
if not variants: if not variants:
frappe.throw(_("Please select at least one attribute value")) frappe.throw(_("Please select at least one attribute value"))
@@ -315,8 +310,7 @@ def enqueue_multiple_variant_creation(item: str, args: dict | str, use_template_
def create_multiple_variants(item, args, use_template_image=False): def create_multiple_variants(item, args, use_template_image=False):
count = 0 count = 0
if isinstance(args, str): args = frappe.parse_json(args)
args = json.loads(args)
args = {key: values for key, values in args.items() if values} args = {key: values for key, values in args.items() if values}
template_item = frappe.get_doc("Item", item) template_item = frappe.get_doc("Item", item)
@@ -483,7 +477,7 @@ def make_variant_item_code(template_item_code, template_item_name, variant):
@frappe.whitelist() @frappe.whitelist()
def create_variant_doc_for_quick_entry(template: str, args: dict | str): def create_variant_doc_for_quick_entry(template: str, args: dict | str):
variant_based_on = frappe.db.get_value("Item", template, "variant_based_on") variant_based_on = frappe.db.get_value("Item", template, "variant_based_on")
args = json.loads(args) args = frappe.parse_json(args)
if variant_based_on == "Manufacturer": if variant_based_on == "Manufacturer":
variant = get_variant(template, **args) variant = get_variant(template, **args)
else: else: