From d82b1fc6009f0d69b1e04d4ba9eda1ea0aae777d Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Fri, 15 Mar 2024 12:08:32 +0530 Subject: [PATCH] refactor(test): generate and use unique party (cherry picked from commit a3d4aff29c61f41629136d93a13b74687ed13d36) --- .../doctype/payment_entry/test_payment_entry.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/erpnext/accounts/doctype/payment_entry/test_payment_entry.py b/erpnext/accounts/doctype/payment_entry/test_payment_entry.py index 3979a6d52cf..c0e425a912a 100644 --- a/erpnext/accounts/doctype/payment_entry/test_payment_entry.py +++ b/erpnext/accounts/doctype/payment_entry/test_payment_entry.py @@ -1516,9 +1516,10 @@ class TestPaymentEntry(FrappeTestCase): self.assertEqual(references[2].payment_term, "Tax Receivable") ======= def test_reverse_payment_reconciliation(self): + customer = create_customer(frappe.generate_hash(length=10), "INR") pe = create_payment_entry( party_type="Customer", - party="_Test Customer", + party=customer, payment_type="Receive", paid_from="Debtors - _TC", paid_to="_Test Cash - _TC", @@ -1527,7 +1528,7 @@ class TestPaymentEntry(FrappeTestCase): reverse_pe = create_payment_entry( party_type="Customer", - party="_Test Customer", + party=customer, payment_type="Pay", paid_from="_Test Cash - _TC", paid_to="Debtors - _TC", @@ -1537,7 +1538,7 @@ class TestPaymentEntry(FrappeTestCase): pr = frappe.get_doc("Payment Reconciliation") pr.company = "_Test Company" pr.party_type = "Customer" - pr.party = "_Test Customer" + pr.party = customer pr.receivable_payable_account = "Debtors - _TC" pr.get_unreconciled_entries() self.assertEqual(len(pr.invoices), 1) @@ -1558,6 +1559,7 @@ class TestPaymentEntry(FrappeTestCase): from erpnext.accounts.doctype.account.test_account import create_account company = "_Test Company" + customer = create_customer(frappe.generate_hash(length=10), "INR") advance_account = create_account( parent_account="Current Assets - _TC", account_name="Advances Received", @@ -1576,7 +1578,7 @@ class TestPaymentEntry(FrappeTestCase): # Reverse Payment(essentially an Invoice) reverse_pe = create_payment_entry( party_type="Customer", - party="_Test Customer", + party=customer, payment_type="Pay", paid_from="_Test Cash - _TC", paid_to=advance_account, @@ -1587,7 +1589,7 @@ class TestPaymentEntry(FrappeTestCase): # Advance Payment pe = create_payment_entry( party_type="Customer", - party="_Test Customer", + party=customer, payment_type="Receive", paid_from=advance_account, paid_to="_Test Cash - _TC", @@ -1599,7 +1601,7 @@ class TestPaymentEntry(FrappeTestCase): pr = frappe.get_doc("Payment Reconciliation") pr.company = company pr.party_type = "Customer" - pr.party = "_Test Customer" + pr.party = customer pr.receivable_payable_account = "Debtors - _TC" pr.default_advance_account = advance_account pr.get_unreconciled_entries()