From d7f4524cddb14d4444fe6d5886ece83a011b406f Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Tue, 14 Jul 2026 16:40:07 +0530 Subject: [PATCH] refactor: convert Hide Currency Symbol in Global Defaults to a Check field (#57135) --- erpnext/patches.txt | 3 ++- .../v16_0/convert_hide_currency_symbol_to_check.py | 9 +++++++++ .../setup/doctype/global_defaults/global_defaults.json | 8 ++++---- erpnext/setup/doctype/global_defaults/global_defaults.py | 2 +- 4 files changed, 16 insertions(+), 6 deletions(-) create mode 100644 erpnext/patches/v16_0/convert_hide_currency_symbol_to_check.py diff --git a/erpnext/patches.txt b/erpnext/patches.txt index 12c13f8aaee..6a9632dc51f 100644 --- a/erpnext/patches.txt +++ b/erpnext/patches.txt @@ -261,6 +261,7 @@ erpnext.patches.v14_0.update_proprietorship_to_individual erpnext.patches.v15_0.rename_subcontracting_fields erpnext.patches.v15_0.unset_incorrect_additional_discount_percentage erpnext.patches.v16_0.convert_commission_rate_to_percent +erpnext.patches.v16_0.convert_hide_currency_symbol_to_check [post_model_sync] erpnext.patches.v15_0.rename_gross_purchase_amount_to_net_purchase_amount @@ -496,4 +497,4 @@ erpnext.patches.v16_0.backfill_pick_list_transferred_qty erpnext.patches.v16_0.create_shop_floor_roles erpnext.patches.v15_0.backfill_sla_link_filters_on_custom_field erpnext.patches.v15_0.backfill_sla_link_filters_on_docfield -erpnext.patches.v16_0.crm_settings_handle_allowed_users_for_frappe_crm \ No newline at end of file +erpnext.patches.v16_0.crm_settings_handle_allowed_users_for_frappe_crm diff --git a/erpnext/patches/v16_0/convert_hide_currency_symbol_to_check.py b/erpnext/patches/v16_0/convert_hide_currency_symbol_to_check.py new file mode 100644 index 00000000000..d3ed8ca5a31 --- /dev/null +++ b/erpnext/patches/v16_0/convert_hide_currency_symbol_to_check.py @@ -0,0 +1,9 @@ +import frappe + + +def execute(): + # runs pre_model_sync: field is still a Select, so this returns the raw "Yes"/"No" + old_value = frappe.db.get_single_value("Global Defaults", "hide_currency_symbol") + new_value = 1 if old_value == "Yes" else 0 + frappe.db.set_single_value("Global Defaults", "hide_currency_symbol", new_value) + frappe.db.set_default("hide_currency_symbol", new_value) diff --git a/erpnext/setup/doctype/global_defaults/global_defaults.json b/erpnext/setup/doctype/global_defaults/global_defaults.json index 908da5ff912..305972a5cea 100644 --- a/erpnext/setup/doctype/global_defaults/global_defaults.json +++ b/erpnext/setup/doctype/global_defaults/global_defaults.json @@ -55,12 +55,12 @@ "reqd": 1 }, { + "default": "0", "description": "Do not show any symbol like $ etc next to currencies.", "fieldname": "hide_currency_symbol", - "fieldtype": "Select", + "fieldtype": "Check", "in_list_view": 1, - "label": "Hide Currency Symbol", - "options": "\nNo\nYes" + "label": "Hide Currency Symbol" }, { "default": "0", @@ -121,7 +121,7 @@ "in_create": 1, "issingle": 1, "links": [], - "modified": "2026-07-14 15:18:25.829886", + "modified": "2026-07-14 18:30:00.000000", "modified_by": "Administrator", "module": "Setup", "name": "Global Defaults", diff --git a/erpnext/setup/doctype/global_defaults/global_defaults.py b/erpnext/setup/doctype/global_defaults/global_defaults.py index 911888b095f..9684566d3a9 100644 --- a/erpnext/setup/doctype/global_defaults/global_defaults.py +++ b/erpnext/setup/doctype/global_defaults/global_defaults.py @@ -53,7 +53,7 @@ class GlobalDefaults(Document): disable_in_words: DF.Check disable_rounded_total: DF.Check enable_company_wise_masters: DF.Check - hide_currency_symbol: DF.Literal["", "No", "Yes"] + hide_currency_symbol: DF.Check use_posting_datetime_for_naming_documents: DF.Check # end: auto-generated types