nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-18 19:07:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(stock): savepoint repost loop in Stock and Account Value Comparison (Postgres)

Browse Source 
The item/warehouse loop submits a Repost Item Valuation; a DuplicateEntryError poisons the Postgres transaction, so the next iteration's .submit() raises InFailedSqlTransaction. MariaDB continues. Savepoint per iteration + rollback(save_point=) on the caught duplicate (mirrors repost_item_valuation:782). No-op on MariaDB.
This commit is contained in:
Mihir Kandoi
2026-06-29 22:37:59 +05:30
parent 91dae91769
commit d7a81affc2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/stock/report/stock_and_account_value_comparison/stock_and_account_value_comparison.py
View File

@@ -202,6 +202,7 @@ def create_reposting_entries(rows: str | list, company: str):
for key, sle in item_wh.items(): for key, sle in item_wh.items():
item_code, warehouse = key item_code, warehouse = key
frappe.db.savepoint("repost_value_comparison")
try: try:
doc = frappe.get_doc( doc = frappe.get_doc(
{ {
@@ -219,7 +220,7 @@ def create_reposting_entries(rows: str | list, company: str):
entries.append(get_link_to_form("Repost Item Valuation", doc.name)) entries.append(get_link_to_form("Repost Item Valuation", doc.name))
except frappe.DuplicateEntryError: except frappe.DuplicateEntryError:
pass frappe.db.rollback(save_point="repost_value_comparison")
if entries: if entries:
entries = ", ".join(entries) entries = ", ".join(entries)