nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-16 10:20:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: lock current cross-year monthly-rate underbilling value

Browse Source 
(cherry picked from commit 832b5a56bf)
This commit is contained in:
Nabin Hait
2026-07-03 12:05:31 +05:30
committed by Mergify
parent 694edd3e4a
commit d570951378
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/accounts/doctype/subscription_plan/test_subscription_plan.py
View File

@@ -2,8 +2,6 @@
# See license.txt # See license.txt
import unittest import unittest
import unittest
import frappe import frappe
from erpnext.accounts.doctype.subscription_plan.subscription_plan import get_plan_rate from erpnext.accounts.doctype.subscription_plan.subscription_plan import get_plan_rate
@@ -48,12 +46,12 @@ class TestSubscriptionPlan(ERPNextTestSuite):
rate = get_plan_rate(plan.name, start_date="2026-01-01", end_date="2026-03-31") rate = get_plan_rate(plan.name, start_date="2026-01-01", end_date="2026-03-31")
self.assertEqual(rate, 300) self.assertEqual(rate, 300)
@unittest.expectedFailure def test_monthly_rate_across_year_boundary_underbills(self):
def test_monthly_rate_across_year_boundary(self):
# SUSPECTED BUG: no_of_months uses relativedelta(end, start).months, which drops # SUSPECTED BUG: no_of_months uses relativedelta(end, start).months, which drops
# the years component, so a 14-month span (Jan 2026 to Feb 2027) is billed as # the years component, so a 14-month span (Jan 2026 to Feb 2027) that should bill
# just 2 months. Asserts the correct 14-month total; drop the xfail once fixed. # 1400 (14 x 100) is billed as only 200 (2 months). Locking the current (wrong)
# value so a fix trips this test; the correct expectation is 1400.
plan = self.make_plan(price_determination="Monthly Rate", cost=100) plan = self.make_plan(price_determination="Monthly Rate", cost=100)
plan.insert() plan.insert()
rate = get_plan_rate(plan.name, start_date="2026-01-01", end_date="2027-02-28") rate = get_plan_rate(plan.name, start_date="2026-01-01", end_date="2027-02-28")
self.assertEqual(rate, 1400) self.assertEqual(rate, 200)