nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-27 00:44:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: refactor long if conditions

Browse Source
This commit is contained in:
anandbaburajan
2023-02-26 15:03:16 +05:30
parent 75386e3653
commit d56ca011fe
1 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
erpnext/assets/doctype/asset/asset.py
View File

@@ -102,29 +102,33 @@ class Asset(AccountsController):
if not old_asset_doc: if not old_asset_doc:
return True return True
if ( have_asset_details_been_modified = (
old_asset_doc.gross_purchase_amount != self.gross_purchase_amount old_asset_doc.gross_purchase_amount != self.gross_purchase_amount
or old_asset_doc.opening_accumulated_depreciation != self.opening_accumulated_depreciation or old_asset_doc.opening_accumulated_depreciation != self.opening_accumulated_depreciation
or old_asset_doc.number_of_depreciations_booked != self.number_of_depreciations_booked or old_asset_doc.number_of_depreciations_booked != self.number_of_depreciations_booked
): )
if have_asset_details_been_modified:
return True return True
manual_fb_idx = -1 manual_fb_idx = -1
for d in self.finance_books: for d in self.finance_books:
if d.depreciation_method == "Manual": if d.depreciation_method == "Manual":
manual_fb_idx = d.idx manual_fb_idx = d.idx - 1
if ( no_manual_depr_or_have_manual_depr_details_been_modified = (
manual_fb_idx == -1 manual_fb_idx == -1
or old_asset_doc.finance_books[manual_fb_idx - 1].total_number_of_depreciations or old_asset_doc.finance_books[manual_fb_idx].total_number_of_depreciations
!= self.finance_books[manual_fb_idx - 1].total_number_of_depreciations != self.finance_books[manual_fb_idx].total_number_of_depreciations
or old_asset_doc.finance_books[manual_fb_idx - 1].frequency_of_depreciation or old_asset_doc.finance_books[manual_fb_idx].frequency_of_depreciation
!= self.finance_books[manual_fb_idx - 1].frequency_of_depreciation != self.finance_books[manual_fb_idx].frequency_of_depreciation
or old_asset_doc.finance_books[manual_fb_idx - 1].depreciation_start_date or old_asset_doc.finance_books[manual_fb_idx].depreciation_start_date
!= getdate(self.finance_books[manual_fb_idx - 1].depreciation_start_date) != getdate(self.finance_books[manual_fb_idx].depreciation_start_date)
or old_asset_doc.finance_books[manual_fb_idx - 1].expected_value_after_useful_life or old_asset_doc.finance_books[manual_fb_idx].expected_value_after_useful_life
!= self.finance_books[manual_fb_idx - 1].expected_value_after_useful_life != self.finance_books[manual_fb_idx].expected_value_after_useful_life
): )
if no_manual_depr_or_have_manual_depr_details_been_modified:
return True return True
return False return False