From ffae7c4175ded3c34f16332f9ed4bc41826ab6d2 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Fri, 21 Nov 2025 11:58:33 +0530 Subject: [PATCH] fix: pricing rule was ignoring time validity --- erpnext/accounts/doctype/pricing_rule/utils.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/pricing_rule/utils.py b/erpnext/accounts/doctype/pricing_rule/utils.py index af970401263..f276235d402 100644 --- a/erpnext/accounts/doctype/pricing_rule/utils.py +++ b/erpnext/accounts/doctype/pricing_rule/utils.py @@ -243,10 +243,13 @@ def get_other_conditions(conditions, values, args): if group_condition: conditions += " and " + group_condition - if args.get("transaction_date"): + date = args.get("transaction_date") or frappe.get_value( + args.get("doctype"), args.get("name"), "posting_date" + ) + if date: conditions += """ and %(transaction_date)s between ifnull(`tabPricing Rule`.valid_from, '2000-01-01') and ifnull(`tabPricing Rule`.valid_upto, '2500-12-31')""" - values["transaction_date"] = args.get("transaction_date") + values["transaction_date"] = date if args.get("doctype") in [ "Quotation",