nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 08:24:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

enhancement: ensure subscription is cancelled before attempting to restart

Browse Source
This commit is contained in:
tundebabzy
2018-03-03 07:37:59 +01:00
parent e13570f343
commit d43422c18e
2 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/accounts/doctype/subscriptions/subscriptions.py
View File

@@ -410,11 +410,14 @@ class Subscriptions(Document):
subscription and the `Subscription` will lose all the history of generated invoices subscription and the `Subscription` will lose all the history of generated invoices
it has. it has.
""" """
self.status = 'Active' if self.status == 'Canceled':
self.db_set('start', nowdate()) self.status = 'Active'
self.update_subscription_period(nowdate()) self.db_set('start', nowdate())
self.invoices = [] self.update_subscription_period(nowdate())
self.save() self.invoices = []
self.save()
else:
frappe.throw(_('You cannot restart a Subscription that is not cancelled.'))
def process_all(): def process_all():

10
erpnext/accounts/doctype/subscriptions/test_subscriptions.py
View File

@@ -447,3 +447,13 @@ class TestSubscriptions(unittest.TestCase):
settings.cancel_after_grace = default_grace_period_action settings.cancel_after_grace = default_grace_period_action
settings.save() settings.save()
subscription.delete() subscription.delete()
def test_restart_active_subscription(self):
subscription = frappe.new_doc('Subscriptions')
subscription.subscriber = '_Test Customer'
subscription.append('plans', {'plan': '_Test Plan Name'})
subscription.save()
self.assertRaises(frappe.ValidationError, subscription.restart_subscription)
subscription.delete()