From d24c2c4ccafec82c185af05eced2daac00da9a2f Mon Sep 17 00:00:00 2001 From: priyanshshah2442 Date: Mon, 9 Jun 2025 17:49:40 +0530 Subject: [PATCH] fix: ensure proper float conversion for discount values (cherry picked from commit 3dcb801a3791a67cf8f38f84700472457a5835e3) --- .../calculated_discount_mismatch.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/report/calculated_discount_mismatch/calculated_discount_mismatch.py b/erpnext/accounts/report/calculated_discount_mismatch/calculated_discount_mismatch.py index 30d13c87afc..e3cba25e8f4 100644 --- a/erpnext/accounts/report/calculated_discount_mismatch/calculated_discount_mismatch.py +++ b/erpnext/accounts/report/calculated_discount_mismatch/calculated_discount_mismatch.py @@ -24,7 +24,7 @@ AFFECTED_DOCTYPES = frozenset( LAST_MODIFIED_DATE_THRESHOLD = "2025-05-30" -def execute(): +def execute(filters=None): columns = get_columns() data = get_data() @@ -137,8 +137,8 @@ def get_data(): if not discount_values: continue - old = discount_values[1] - new = discount_values[2] + old = flt(discount_values[1][2:]) + new = flt(discount_values[2][2:]) doc_values = transactions_with_discount_percentage.get(doc) if new != doc_values.discount_amount: # if the discount amount in the version is not equal to the current value, skip