nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-13 18:21:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: While submitting PCV ensure previous FY is closed (#42284)

Browse Source
This commit is contained in:
Nabin Hait
2024-07-12 14:24:42 +05:30
committed by GitHub
parent 9838f7e6ba
commit d0bbc8ca70
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
View File

@@ -136,18 +136,28 @@ class PeriodClosingVoucher(AccountsController):
def check_if_previous_year_closed(self): def check_if_previous_year_closed(self):
last_year_closing = add_days(self.year_start_date, -1) last_year_closing = add_days(self.year_start_date, -1)
previous_fiscal_year = get_fiscal_year(last_year_closing, company=self.company, boolean=True) previous_fiscal_year = get_fiscal_year(last_year_closing, company=self.company, boolean=True)
if not previous_fiscal_year:
return
if previous_fiscal_year and not frappe.db.exists( previous_fiscal_year_start_date = previous_fiscal_year[0][1]
if not frappe.db.exists(
"GL Entry", "GL Entry",
{"posting_date": ("<=", last_year_closing), "company": self.company, "is_cancelled": 0}, {
"posting_date": ("between", [previous_fiscal_year_start_date, last_year_closing]),
"company": self.company,
"is_cancelled": 0,
},
): ):
return return
if previous_fiscal_year and not frappe.db.exists( if not frappe.db.exists(
"Period Closing Voucher", "Period Closing Voucher",
{"posting_date": ("<=", last_year_closing), "docstatus": 1, "company": self.company}, {
"posting_date": ("between", [previous_fiscal_year_start_date, last_year_closing]),
"docstatus": 1,
"company": self.company,
},
): ):
frappe.throw(_("Previous Year is not closed, please close it first")) frappe.throw(_("Previous Year is not closed, please close it first"))