Merge pull request #27333 from marination/subcontr-serial-no

fix: Prematurely referenced variable in buying controller for subcontracting
This commit is contained in:
Marica
2021-09-03 20:56:02 +05:30
committed by GitHub

View File

@@ -983,11 +983,11 @@ def get_non_stock_items(purchase_order, fg_item_code):
def set_serial_nos(raw_material, consumed_serial_nos, qty): def set_serial_nos(raw_material, consumed_serial_nos, qty):
consumed_serial_nos_list = [] consumed_serial_nos_list = []
if isinstance(consumed_serial_nos, list): if consumed_serial_nos and isinstance(consumed_serial_nos, list):
for row in consumed_serial_nos: for row in consumed_serial_nos:
consumed_serial_nos_list.extend(get_serial_nos(row)) consumed_serial_nos_list.extend(get_serial_nos(row))
else: elif consumed_serial_nos:
consumed_serial_nos_list = get_serial_nos(row) consumed_serial_nos_list = get_serial_nos(consumed_serial_nos)
serial_nos = set(get_serial_nos(raw_material.serial_nos)) - set(consumed_serial_nos_list) serial_nos = set(get_serial_nos(raw_material.serial_nos)) - set(consumed_serial_nos_list)