refactor(test): remove redundant clear method and minor fixes

(cherry picked from commit 004087097c)

erpnext/accounts/doctype/advance_payment_ledger_entry/test_advance_payment_ledger_entry.py

@@ -29,7 +29,6 @@ class TestAdvancePaymentLedgerEntry(ERPNextTestSuite, AccountsTestMixin):
 		self.cash = "Cash - _TC"
 		self.debtors_usd = "_Test Receivable USD - _TC"
 		self.creditors_usd = "_Test Payable USD - _TC"
-		self.clear_old_entries()
 
 	def create_sales_order(self, qty=1, rate=100, currency="INR", do_not_submit=False):
 		"""

erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py

@@ -21,7 +21,6 @@ class TestBankReconciliationTool(ERPNextTestSuite, AccountsTestMixin):
 		self.customer = "_Test Customer"
 		self.bank = "HDFC - _TC"
 		self.debit_to = "Debtors - _TC"
-		self.clear_old_entries()
 		bank_dt = qb.DocType("Bank")
 		qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()
 		self.create_bank_account()

erpnext/accounts/doctype/bank_statement_import_log/test_bank_statement_import_log.py

@@ -29,7 +29,6 @@ class TestBankStatementImportLog(ERPNextTestSuite, AccountsTestMixin):
 		self.company = "_Test Company"
 		self.customer = "_Test Customer"
 		self.bank = "HDFC - _TC"
-		self.clear_old_entries()
 		bank_dt = qb.DocType("Bank")
 		qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()
 		self.create_bank_account()

erpnext/accounts/doctype/bank_transaction_rule/test_bank_transaction_rule.py

@@ -16,7 +16,6 @@ class TestBankTransactionRule(ERPNextTestSuite, AccountsTestMixin):
 		self.bank = "HDFC - _TC"
 		self.debit_to = "Debtors - _TC"
 		self.cash = "Cash - _TC"
-		self.clear_old_entries()
 		bank_dt = qb.DocType("Bank")
 		qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()
 		self.create_bank_account()

erpnext/accounts/doctype/exchange_rate_revaluation/test_exchange_rate_revaluation.py

@@ -20,7 +20,6 @@ class TestExchangeRateRevaluation(ERPNextTestSuite, AccountsTestMixin):
 		self.customer = "_Test Customer"
 		self.cost_center = "Main - _TC"
 		self.debtors_usd = "_Test Receivable USD - _TC"
-		self.clear_old_entries()
 		self.set_system_and_company_settings()
 
 	def set_system_and_company_settings(self):

erpnext/accounts/doctype/ledger_health/test_ledger_health.py

@@ -17,7 +17,6 @@ class TestLedgerHealth(ERPNextTestSuite, AccountsTestMixin):
 		self.debit_to = "Debtors - _TC"
 		self.income_account = "Sales - _TC"
 		self.configure_monitoring_tool()
-		self.clear_old_entries()
 
 	def configure_monitoring_tool(self):
 		monitor_settings = frappe.get_doc("Ledger Health Monitor")

erpnext/accounts/doctype/payment_ledger_entry/test_payment_ledger_entry.py

@@ -20,7 +20,6 @@ class TestPaymentLedgerEntry(ERPNextTestSuite):
 		self.create_company()
 		self.create_item()
 		self.create_customer()
-		self.clear_old_entries()
 
 	def create_company(self):
 		company_name = "_Test Payment Ledger"

erpnext/accounts/doctype/process_statement_of_accounts/test_process_statement_of_accounts.py

@@ -23,7 +23,6 @@ class TestProcessStatementOfAccounts(ERPNextTestSuite, AccountsTestMixin):
 
 		self.company = "_Test Company"
 		self.create_customer(customer_name="Other Customer")
-		self.clear_old_entries()
 		self.si = create_sales_invoice()
 		create_sales_invoice(customer="Other Customer")
 

erpnext/accounts/doctype/unreconcile_payment/test_unreconcile_payment.py

@@ -24,7 +24,6 @@ class TestUnreconcilePayment(ERPNextTestSuite, AccountsTestMixin):
 		self.cost_center = "Main - _TC"
 		self.cash = "Cash - _TC"
 		self.debtors_usd = "_Test Receivable USD - _TC"
-		self.clear_old_entries()
 
 	def create_sales_invoice(self, do_not_submit=False):
 		si = create_sales_invoice(
@@ -375,7 +374,6 @@ class TestUnreconcilePayment(ERPNextTestSuite, AccountsTestMixin):
 		self.assertEqual(so.advance_paid, 0)
 
 	def test_06_unreconcile_advance_from_payment_entry(self):
-		self.enable_advance_as_liability()
 		so1 = self.create_sales_order()
 		so2 = self.create_sales_order()
 
@@ -426,7 +424,11 @@ class TestUnreconcilePayment(ERPNextTestSuite, AccountsTestMixin):
 		self.disable_advance_as_liability()
 
 	def test_07_adv_from_so_to_invoice(self):
-		self.enable_advance_as_liability()
+		frappe.db.set_value("Company", self.company, "book_advance_payments_in_separate_party_account", True)
+		frappe.db.set_value(
+			"Company", self.company, "default_advance_received_account", "Advance Received - _TC"
+		)
+
 		so = self.create_sales_order()
 		pe = self.create_payment_entry()
 		pe.paid_amount = 1000

erpnext/accounts/report/accounts_payable/test_accounts_payable.py

@@ -11,7 +11,7 @@ class TestAccountsPayable(ERPNextTestSuite, AccountsTestMixin):
 	def setUp(self):
 		self.company = "_Test Company"
 		self.item = "_Test Item"
-		self.supplier = "_Test Supplier USD"
+		self.supplier = "_Test Supplier 2"
 		self.creditors_usd = "_Test Payable USD - _TC"
 
 	def test_accounts_payable_for_foreign_currency_supplier(self):

erpnext/accounts/report/accounts_receivable/test_accounts_receivable.py

@@ -23,7 +23,6 @@ class TestAccountsReceivable(ERPNextTestSuite, AccountsTestMixin):
 		self.debit_to = "Debtors - _TC"
 		self.cash = "Cash - _TC"
 		self.debtors_usd = "_Test Receivable USD - _TC"
-		self.clear_old_entries()
 
 	def create_sales_invoice(self, no_payment_schedule=False, do_not_submit=False, **args):
 		frappe.set_user("Administrator")

erpnext/accounts/report/accounts_receivable_summary/test_accounts_receivable_summary.py

@@ -16,7 +16,6 @@ class TestAccountsReceivable(ERPNextTestSuite, AccountsTestMixin):
 		self.item = "_Test Item"
 		self.debit_to = "Debtors - _TC"
 		self.cost_center = "Main - _TC"
-		self.clear_old_entries()
 
 	def test_01_receivable_summary_output(self):
 		"""

erpnext/accounts/report/customer_ledger_summary/test_customer_ledger_summary.py

@@ -18,7 +18,6 @@ class TestCustomerLedgerSummary(ERPNextTestSuite, AccountsTestMixin):
 		self.debit_to = "Debtors - _TC"
 		self.cost_center = "Main - _TC"
 		self.cash = "Cash - _TC"
-		self.clear_old_entries()
 
 	def create_sales_invoice(self, do_not_submit=False, **args):
 		si = create_sales_invoice(

erpnext/accounts/report/deferred_revenue_and_expense/test_deferred_revenue_and_expense.py

@@ -71,7 +71,6 @@ class TestDeferredRevenueAndExpense(ERPNextTestSuite, AccountsTestMixin):
 		self.income_account = "Sales - _TC"
 		self.expense_account = "Cost of Goods Sold - _TC"
 		self.setup_deferred_accounts_and_items()
-		self.clear_old_entries()
 
 	@ERPNextTestSuite.change_settings("Accounts Settings", {"book_deferred_entries_based_on": "Months"})
 	def test_deferred_revenue(self):

erpnext/accounts/report/general_ledger/test_general_ledger.py

@@ -14,7 +14,6 @@ from erpnext.tests.utils import ERPNextTestSuite
 class TestGeneralLedger(ERPNextTestSuite):
 	def setUp(self):
 		self.company = "_Test Company"
-		self.clear_old_entries()
 
 	def clear_old_entries(self):
 		doctype_list = [

erpnext/accounts/report/gross_profit/test_gross_profit.py

@@ -18,8 +18,6 @@ class TestGrossProfit(ERPNextTestSuite):
 		self.create_item()
 		self.create_bundle()
 		self.create_customer()
-		self.create_sales_invoice()
-		self.clear_old_entries()
 
 	def create_company(self):
 		company_name = "_Test Gross Profit"

erpnext/accounts/report/supplier_ledger_summary/test_supplier_ledger_summary.py

@@ -12,7 +12,6 @@ class TestSupplierLedgerSummary(ERPNextTestSuite, AccountsTestMixin):
 		self.company = "_Test Company"
 		self.supplier = "_Test Supplier"
 		self.item = "_Test Item"
-		self.clear_old_entries()
 
 	def create_purchase_invoice(self, do_not_submit=False):
 		frappe.set_user("Administrator")

erpnext/accounts/report/tax_withholding_details/test_tax_withholding_details.py

@@ -21,7 +21,6 @@ from erpnext.tests.utils import ERPNextTestSuite
 class TestTaxWithholdingDetails(ERPNextTestSuite, AccountsTestMixin):
 	def setUp(self):
 		self.company = "_Test Company"
-		self.clear_old_entries()
 		create_records()
 
 	def test_tax_withholding_for_customers(self):