nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-13 18:21:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: phone number field when channel is phone on Payment Request (#44949)

Browse Source 
Co-authored-by: maniamartial <martialamania19@gmail.com>
This commit is contained in:
Joseph Mania
2025-01-04 02:53:41 +03:00
committed by GitHub
parent 500deff3e9
commit cfa062df86
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/accounts/doctype/payment_request/payment_request.json
View File

@@ -58,7 +58,9 @@
"payment_account", "payment_account",
"payment_channel", "payment_channel",
"payment_order", "payment_order",
"amended_from" "amended_from",
"column_break_iiuv",
"phone_number"
], ],
"fields": [ "fields": [
{ {
@@ -376,6 +378,7 @@
"read_only": 1 "read_only": 1
}, },
{ {
"depends_on": "eval: doc.payment_channel==\"Phone\"",
"fetch_from": "payment_gateway_account.payment_channel", "fetch_from": "payment_gateway_account.payment_channel",
"fieldname": "payment_channel", "fieldname": "payment_channel",
"fieldtype": "Select", "fieldtype": "Select",
@@ -429,13 +432,22 @@
"fieldtype": "Data", "fieldtype": "Data",
"label": "Party Name", "label": "Party Name",
"read_only": 1 "read_only": 1
},
{
"fieldname": "column_break_iiuv",
"fieldtype": "Column Break"
},
{
"fieldname": "phone_number",
"fieldtype": "Data",
"label": "Phone Number"
} }
], ],
"in_create": 1, "in_create": 1,
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"is_submittable": 1, "is_submittable": 1,
"links": [], "links": [],
"modified": "2024-10-23 12:23:40.117336", "modified": "2024-12-27 21:29:10.361894",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Payment Request", "name": "Payment Request",

2
erpnext/accounts/doctype/payment_request/payment_request.py
View File

@@ -224,6 +224,7 @@ class PaymentRequest(Document):
sender=self.email_to, sender=self.email_to,
currency=self.currency, currency=self.currency,
payment_gateway=self.payment_gateway, payment_gateway=self.payment_gateway,
phone_number=self.phone_number,
) )
controller.validate_transaction_currency(self.currency) controller.validate_transaction_currency(self.currency)
@@ -635,6 +636,7 @@ def make_payment_request(**args):
"party": args.get("party") or ref_doc.get("customer"), "party": args.get("party") or ref_doc.get("customer"),
"bank_account": bank_account, "bank_account": bank_account,
"party_name": args.get("party_name") or ref_doc.get("customer_name"), "party_name": args.get("party_name") or ref_doc.get("customer_name"),
"phone_number": args.get("phone_number") if args.get("phone_number") else None,
} }
) )