nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-15 18:01:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(manufacturing): bound transfer guard by the claim sum

Browse Source 
The per-submit allowance guard projected stored effective transferred
qty plus the entry claim, so claim-less coverage (pick list, material
request) and corrective job card transfers wrongly consumed the claim
budget (test_corrective_job_card_transfer_excluded_from_transferred_qty).
Bound the projection by the claim sum, which already excludes corrective
and additional entries.
This commit is contained in:
Mihir Kandoi
2026-08-13 12:20:13 +05:30
parent 99e2538b25
commit ce0cdfb492
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/stock/doctype/stock_entry/services/material_transfer.py
View File

@@ -394,7 +394,9 @@ class MaterialTransferForManufactureStockEntry(BaseMaterialTransferStockEntry):
def _validate_transfer_within_allowance(self): def _validate_transfer_within_allowance(self):
"""Reject a transfer whose For Quantity, on top of the effective qty already """Reject a transfer whose For Quantity, on top of the effective qty already
transferred, exceeds the planned qty plus the transfer allowance.""" transferred, exceeds the planned qty plus the transfer allowance. The projection
is bounded by the claim sum, which already excludes corrective job card and
additional transfer entries, so claim-less coverage never consumes the budget."""
from erpnext.manufacturing.doctype.work_order.services.status import StatusService from erpnext.manufacturing.doctype.work_order.services.status import StatusService
from erpnext.manufacturing.doctype.work_order.work_order import StockOverProductionError from erpnext.manufacturing.doctype.work_order.work_order import StockOverProductionError
@@ -405,10 +407,14 @@ class MaterialTransferForManufactureStockEntry(BaseMaterialTransferStockEntry):
if self.wo_doc.operations and self.wo_doc.transfer_material_against == "Job Card": if self.wo_doc.operations and self.wo_doc.transfer_material_against == "Job Card":
return return
allowance = StatusService(self.wo_doc).get_qty_allowance("Material Transfer for Manufacture") status_service = StatusService(self.wo_doc)
allowance = status_service.get_qty_allowance("Material Transfer for Manufacture")
allowed_qty = flt(self.wo_doc.qty) * (1.0 + allowance / 100.0) allowed_qty = flt(self.wo_doc.qty) * (1.0 + allowance / 100.0)
transferred_qty = flt(self.wo_doc.material_transferred_for_manufacturing) transferred_qty = flt(self.wo_doc.material_transferred_for_manufacturing)
projected_qty = transferred_qty + flt(self.doc.fg_completed_qty) claimed_qty = status_service.get_transferred_or_manufactured_qty(
"Material Transfer for Manufacture", "material_transferred_for_manufacturing"
)
projected_qty = min(transferred_qty + flt(self.doc.fg_completed_qty), claimed_qty)
precision = self.wo_doc.precision("material_transferred_for_manufacturing") precision = self.wo_doc.precision("material_transferred_for_manufacturing")
if flt(projected_qty, precision) <= flt(allowed_qty, precision): if flt(projected_qty, precision) <= flt(allowed_qty, precision):
return return